From: Alexandre Belloni <alexandre.belloni@bootlin•com>
To: Mark Brown <broonie@kernel•org>
Cc: Detlev Casanova <detlev.casanova@collabora•com>,
linux-kernel@vger•kernel.org,
Nicolas Frattaroli <frattaroli.nicolas@gmail•com>,
Liam Girdwood <lgirdwood@gmail•com>,
Jaroslav Kysela <perex@perex•cz>, Takashi Iwai <tiwai@suse•com>,
Heiko Stuebner <heiko@sntech•de>,
linux-rockchip@lists•infradead.org, linux-sound@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, kernel@collabora•com,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
Luca Ceresoli <luca.ceresoli@bootlin•com>
Subject: Re: [PATCH] ASoC: rockchip: i2s-tdm: Use param rate if not provided by set_sysclk
Date: Thu, 19 Feb 2026 14:30:44 +0100 [thread overview]
Message-ID: <20260219133044fa1ac2a4@mail.local> (raw)
In-Reply-To: <00698644-63dd-45b0-b43b-a7bc0fa459b1@sirena.org.uk>
On 19/02/2026 12:34:44+0000, Mark Brown wrote:
> On Thu, Feb 19, 2026 at 10:37:18AM +0100, Alexandre Belloni wrote:
> > On 18/02/2026 15:18:34-0500, Detlev Casanova wrote:
>
> > > + if (!mclk_rate)
> > > + mclk_rate = DEFAULT_MCLK_FS * params_rate(params);
> > > +
>
> > Maybe this could be set as the default value of i2s_tdm->mclk_rx_freq
> > and i2s_tdm->mclk_tx_freq in rockchip_i2s_tdm_probe instead of relying
> > on it being 0 and testing later on?
>
> That makes sense but since this is fixing a regression and I'd like to
> get the fix in I'll apply, we can improve things incrementally.
Yeah, actually, Luca pointed that it is actually not a good suggestion
because we need the rate of the stream to be able to set mclk_rate and
we obviously don't have it in probe. So you can definitely apply the
patch as-is.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-02-19 13:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 20:18 [PATCH] ASoC: rockchip: i2s-tdm: Use param rate if not provided by set_sysclk Detlev Casanova
2026-02-18 21:02 ` Detlev Casanova
2026-02-19 16:51 ` Luca Ceresoli
2026-02-19 9:37 ` Alexandre Belloni
2026-02-19 12:34 ` Mark Brown
2026-02-19 13:30 ` Alexandre Belloni [this message]
2026-02-19 15:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219133044fa1ac2a4@mail.local \
--to=alexandre.belloni@bootlin$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=detlev.casanova@collabora$(echo .)com \
--cc=frattaroli.nicolas@gmail$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=kernel@collabora$(echo .)com \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-sound@vger$(echo .)kernel.org \
--cc=luca.ceresoli@bootlin$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=tiwai@suse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox