From: Krzysztof Kozlowski <krzysztof.kozlowski@oss•qualcomm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
"Rafael J. Wysocki" <rafael@kernel•org>,
Danilo Krummrich <dakr@kernel•org>,
Jonathan Corbet <corbet@lwn•net>,
Shuah Khan <skhan@linuxfoundation•org>, Tejun Heo <tj@kernel•org>,
Lai Jiangshan <jiangshanlai@gmail•com>,
Tobias Schrammm <t.schramm@manjaro•org>,
Sebastian Reichel <sre@kernel•org>,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Dan Carpenter <dan.carpenter@linaro•org>,
Krzysztof Kozlowski <krzk@kernel•org>, Lee Jones <lee@kernel•org>,
Dzmitry Sankouski <dsankouski@gmail•com>,
Matthias Brugger <matthias.bgg@gmail•com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora•com>,
Benson Leung <bleung@chromium•org>,
Tzung-Bi Shih <tzungbi@kernel•org>
Cc: Matti Vaittinen <mazziesaccount@gmail•com>,
driver-core@lists•linux.dev, linux-doc@vger•kernel.org,
linux-kernel@vger•kernel.org,
Sebastian Reichel <sebastian.reichel@collabora•com>,
linux-pm@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-mediatek@lists•infradead.org,
chrome-platform@lists•linux.dev,
Krzysztof Kozlowski <krzysztof.kozlowski@oss•qualcomm.com>
Subject: [PATCH v2 08/10] mfd: ezx-pcap: Return directly instead of empty gotos
Date: Thu, 05 Mar 2026 22:45:47 +0100 [thread overview]
Message-ID: <20260305-workqueue-devm-v2-8-66a38741c652@oss.qualcomm.com> (raw)
In-Reply-To: <20260305-workqueue-devm-v2-0-66a38741c652@oss.qualcomm.com>
Code is easier to read if empty error paths simply return, instead of
jumping to empty label doing only "return ret".
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss•qualcomm.com>
---
drivers/mfd/ezx-pcap.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
index cd0520a08224..8e51c113a320 100644
--- a/drivers/mfd/ezx-pcap.c
+++ b/drivers/mfd/ezx-pcap.c
@@ -384,17 +384,15 @@ static int ezx_pcap_probe(struct spi_device *spi)
struct pcap_platform_data *pdata = dev_get_platdata(&spi->dev);
struct pcap_chip *pcap;
int i, adc_irq;
- int ret = -ENODEV;
+ int ret;
/* platform data is required */
if (!pdata)
- goto ret;
+ return -ENODEV;
pcap = devm_kzalloc(&spi->dev, sizeof(*pcap), GFP_KERNEL);
- if (!pcap) {
- ret = -ENOMEM;
- goto ret;
- }
+ if (!pcap)
+ return -ENOMEM;
spin_lock_init(&pcap->io_lock);
spin_lock_init(&pcap->adc_lock);
@@ -407,17 +405,15 @@ static int ezx_pcap_probe(struct spi_device *spi)
spi->mode = SPI_MODE_0 | (pdata->config & PCAP_CS_AH ? SPI_CS_HIGH : 0);
ret = spi_setup(spi);
if (ret)
- goto ret;
+ return ret;
pcap->spi = spi;
/* setup irq */
pcap->irq_base = pdata->irq_base;
pcap->workqueue = create_singlethread_workqueue("pcapd");
- if (!pcap->workqueue) {
- ret = -ENOMEM;
- goto ret;
- }
+ if (!pcap->workqueue)
+ return -ENOMEM;
/* redirect interrupts to AP, except adcdone2 */
if (!(pdata->config & PCAP_SECOND_PORT))
--
2.51.0
next prev parent reply other threads:[~2026-03-05 21:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 21:45 [PATCH v2 00/10] workqueue / drivers: Add device-managed allocate workqueue Krzysztof Kozlowski
2026-03-05 21:45 ` [PATCH v2 01/10] workqueue: devres: " Krzysztof Kozlowski
2026-03-06 4:08 ` Tejun Heo
2026-03-10 9:59 ` Krzysztof Kozlowski
2026-03-10 17:05 ` Tejun Heo
2026-03-05 21:45 ` [PATCH v2 02/10] power: supply: cw2015: Free allocated workqueue Krzysztof Kozlowski
2026-03-05 21:45 ` [PATCH v2 03/10] power: supply: max77705: Drop duplicated IRQ error message Krzysztof Kozlowski
2026-03-05 21:45 ` [PATCH v2 04/10] power: supply: max77705: Free allocated workqueue and fix removal order Krzysztof Kozlowski
2026-03-05 21:45 ` [PATCH v2 05/10] power: supply: mt6370: Simplify with devm_alloc_ordered_workqueue() Krzysztof Kozlowski
2026-03-05 21:45 ` [PATCH v2 06/10] power: supply: ipaq_micro: Simplify with devm Krzysztof Kozlowski
2026-03-05 21:45 ` [PATCH v2 07/10] mfd: ezx-pcap: Drop memory allocation error message Krzysztof Kozlowski
2026-03-05 21:45 ` Krzysztof Kozlowski [this message]
2026-03-05 21:45 ` [PATCH v2 09/10] mfd: ezx-pcap: Avoid rescheduling after destroying workqueue Krzysztof Kozlowski
2026-03-05 21:45 ` [PATCH v2 10/10] platform/chrome: cros_usbpd_logger: Simplify with devm Krzysztof Kozlowski
2026-03-10 3:26 ` Tzung-Bi Shih
2026-03-06 14:28 ` [PATCH v2 00/10] workqueue / drivers: Add device-managed allocate workqueue Andy Shevchenko
2026-03-11 7:10 ` (subset) " Sebastian Reichel
2026-03-19 16:21 ` Lee Jones
2026-03-20 3:06 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305-workqueue-devm-v2-8-66a38741c652@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss$(echo .)qualcomm.com \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=bleung@chromium$(echo .)org \
--cc=chrome-platform@lists$(echo .)linux.dev \
--cc=corbet@lwn$(echo .)net \
--cc=dakr@kernel$(echo .)org \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=driver-core@lists$(echo .)linux.dev \
--cc=dsankouski@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jiangshanlai@gmail$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=lee@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mazziesaccount@gmail$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=sebastian.reichel@collabora$(echo .)com \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=sre@kernel$(echo .)org \
--cc=t.schramm@manjaro$(echo .)org \
--cc=tj@kernel$(echo .)org \
--cc=tzungbi@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox