Subject: Re: [PATCH v9 03/23] dt-bindings: ufs: mediatek,ufs: Add mt8196 variant

From: Rob Herring <[email-masked]>
Date: Fri, 6 Mar 2026 10:33:05 -0600

On Fri, Mar 06, 2026 at 02:24:44PM +0100, Nicolas Frattaroli wrote:
> The MediaTek MT8196 SoC's UFS controller uses three additional clocks
> compared to the MT8195, and a different set of supplies. It is therefore
> not compatible with the MT8195.
> 
> While it does have a AVDD09_UFS_1 pin in addition to the AVDD09_UFS pin,
> it appears that these two pins are commoned together, as the board
> schematic I have access to uses the same supply for both, and the
> downstream driver does not distinguish between the two supplies either.
> 
> Add a compatible for it, and modify the binding correspondingly.
> 
> Reviewed-by: Conor Dooley <[email-masked]>
> Acked-by: Vinod Koul <[email-masked]>
> Acked-by: Conor Dooley <[email-masked]>
> Reviewed-by: AngeloGioacchino Del Regno <[email-masked]>
> Signed-off-by: Nicolas Frattaroli <[email-masked]>
> ---
>  .../devicetree/bindings/ufs/mediatek,ufs.yaml      | 58 +++++++++++++++++++++-
>  1 file changed, 57 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> index e0aef3e5f56b..a82119ecbfe8 100644
> --- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> @@ -16,10 +16,11 @@ properties:
>        - mediatek,mt8183-ufshci
>        - mediatek,mt8192-ufshci
>        - mediatek,mt8195-ufshci
> +      - mediatek,mt8196-ufshci
>  
>    clocks:
>      minItems: 1
> -    maxItems: 13
> +    maxItems: 16
>  
>    clock-names:
>      minItems: 1
> @@ -37,6 +38,9 @@ properties:
>        - const: crypt_perf
>        - const: ufs_rx_symbol0
>        - const: ufs_rx_symbol1
> +      - const: ufs_sel

"ufs" is redundant as all the clocks are for UFS. Same comment on prior 
patch.

> +      - const: ufs_sel_min_src
> +      - const: ufs_sel_max_src

"src" sounds like a parent clock? If so, probably shouldn't be in the 
clocks list. 'assigned-clocks' is for dealing with parent clocks.

Rob