Subject: Re: [PATCH v3 3/3] iommu/arm-smmu-v3: Allow ATS to be always on

From: Jason Gunthorpe <[email-masked]>
Date: Tue, 31 Mar 2026 09:08:16 -0300

On Tue, Mar 31, 2026 at 08:40:17AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <[email-masked]>
> > Sent: Saturday, March 7, 2026 7:41 AM
> > 
> > +
> > +	master->ats_always_on = true;
> > +
> > +	ret = arm_smmu_alloc_cd_tables(master);
> > +	if (ret)
> > +		return ret;
> > +
> > +out_prepare:
> > +	pci_prepare_ats(pdev, stu);
> > +	return 0;
> 
> is there a problem leaving ats_always_on being true while
> allocating cd tables fails?

I would expect this error flow unwinds back up to failing device
probe?

Jason