From: Thomas Gleixner <tglx@kernel•org>
To: LKML <linux-kernel@vger•kernel.org>
Cc: Arnd Bergmann <arnd@arndb•de>,
x86@kernel•org, Lu Baolu <baolu.lu@linux•intel.com>,
iommu@lists•linux.dev,
Michael Grzeschik <m.grzeschik@pengutronix•de>,
netdev@vger•kernel.org, linux-wireless@vger•kernel.org,
Herbert Xu <herbert@gondor•apana.org.au>,
linux-crypto@vger•kernel.org, Vlastimil Babka <vbabka@kernel•org>,
linux-mm@kvack•org, David Woodhouse <dwmw2@infradead•org>,
Bernie Thompson <bernie@plugable•com>,
linux-fbdev@vger•kernel.org, "Theodore Tso" <tytso@mit•edu>,
linux-ext4@vger•kernel.org,
Andrew Morton <akpm@linux-foundation•org>,
Uladzislau Rezki <urezki@gmail•com>,
Marco Elver <elver@google•com>,
Dmitry Vyukov <dvyukov@google•com>,
kasan-dev@googlegroups•com,
Andrey Ryabinin <ryabinin.a.a@gmail•com>,
Thomas Sailer <t.sailer@alumni•ethz.ch>,
linux-hams@vger•kernel.org,
"Jason A. Donenfeld" <Jason@zx2c4•com>,
Richard Henderson <richard.henderson@linaro•org>,
linux-alpha@vger•kernel.org, Russell King <linux@armlinux•org.uk>,
linux-arm-kernel@lists•infradead.org,
Catalin Marinas <catalin.marinas@arm•com>,
Huacai Chen <chenhuacai@kernel•org>,
loongarch@lists•linux.dev,
Geert Uytterhoeven <geert@linux-m68k•org>,
linux-m68k@lists•linux-m68k.org,
Dinh Nguyen <dinguyen@kernel•org>,
Jonas Bonn <jonas@southpole•se>,
linux-openrisc@vger•kernel.org, Helge Deller <deller@gmx•de>,
linux-parisc@vger•kernel.org,
Michael Ellerman <mpe@ellerman•id.au>,
linuxppc-dev@lists•ozlabs.org, Paul Walmsley <pjw@kernel•org>,
linux-riscv@lists•infradead.org,
Heiko Carstens <hca@linux•ibm.com>,
linux-s390@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>,
sparclinux@vger•kernel.org
Subject: [patch 01/38] percpu: Sanitize __percpu_qual include hell
Date: Fri, 10 Apr 2026 14:18:32 +0200 [thread overview]
Message-ID: <20260410120317.642797961@kernel.org> (raw)
In-Reply-To: 20260410120044.031381086@kernel.org
Slapping __percpu_qual into the next available header is sloppy at best.
It's required by __percpu which is defined in compiler_types.h and that is
meant to be included without requiring a boatload of other headers so that
a struct or function declaration can contain a __percpu qualifier w/o
further prerequisites.
This implicit dependency on linux/percpu.h makes that impossible and causes
a major problem when trying to seperate headers.
Create asm/percpu_types.h and move it there. Include that from
compiler_types.h and the whole recursion problem goes away.
Signed-off-by: Thomas Gleixner <tglx@kernel•org
Cc: Arnd Bergmann <arnd@arndb•de>
---
arch/x86/include/asm/percpu.h | 5 -----
arch/x86/include/asm/percpu_types.h | 17 +++++++++++++++++
include/asm-generic/Kbuild | 1 +
include/asm-generic/percpu_types.h | 20 ++++++++++++++++++++
include/linux/compiler_types.h | 1 +
5 files changed, 39 insertions(+), 5 deletions(-)
--- a/arch/x86/include/asm/percpu.h
+++ b/arch/x86/include/asm/percpu.h
@@ -40,12 +40,10 @@
#endif
#define __percpu_prefix
-#define __percpu_seg_override CONCATENATE(__seg_, __percpu_seg)
#else /* !CONFIG_CC_HAS_NAMED_AS: */
#define __percpu_prefix __force_percpu_prefix
-#define __percpu_seg_override
#endif /* CONFIG_CC_HAS_NAMED_AS */
@@ -82,7 +80,6 @@
#define __force_percpu_prefix
#define __percpu_prefix
-#define __percpu_seg_override
#define PER_CPU_VAR(var) (var)__percpu_rel
@@ -92,8 +89,6 @@
# define __my_cpu_type(var) typeof(var)
# define __my_cpu_ptr(ptr) (ptr)
# define __my_cpu_var(var) (var)
-
-# define __percpu_qual __percpu_seg_override
#else
# define __my_cpu_type(var) typeof(var) __percpu_seg_override
# define __my_cpu_ptr(ptr) (__my_cpu_type(*(ptr))*)(__force uintptr_t)(ptr)
--- /dev/null
+++ b/arch/x86/include/asm/percpu_types.h
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _ASM_X86_PERCPU_TYPES_H
+#define _ASM_X86_PERCPU_TYPES_H
+
+#if defined(CONFIG_SMP) && defined(CONFIG_CC_HAS_NAMED_AS)
+#define __percpu_seg_override CONCATENATE(__seg_, __percpu_seg)
+#else /* !CONFIG_CC_HAS_NAMED_AS: */
+#define __percpu_seg_override
+#endif
+
+#if defined(CONFIG_USE_X86_SEG_SUPPORT) && defined(USE_TYPEOF_UNQUAL)
+#define __percpu_qual __percpu_seg_override
+#endif
+
+#include <asm-generic/percpu_types.h>
+
+#endif
--- a/include/asm-generic/Kbuild
+++ b/include/asm-generic/Kbuild
@@ -44,6 +44,7 @@ mandatory-y += module.lds.h
mandatory-y += msi.h
mandatory-y += pci.h
mandatory-y += percpu.h
+mandatory-y += percpu_types.h
mandatory-y += pgalloc.h
mandatory-y += preempt.h
mandatory-y += rqspinlock.h
--- /dev/null
+++ b/include/asm-generic/percpu_types.h
@@ -0,0 +1,20 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _ASM_GENERIC_PERCPU_TYPES_H_
+#define _ASM_GENERIC_PERCPU_TYPES_H_
+
+#ifndef __ASSEMBLER__
+/*
+ * __percpu_qual is the qualifier for the percpu named address space.
+ *
+ * Most arches use generic named address space for percpu variables but
+ * some arches define percpu variables in different named address space
+ * (on the x86 arch, percpu variable may be declared as being relative
+ * to the %fs or %gs segments using __seg_fs or __seg_gs named address
+ * space qualifier).
+ */
+#ifndef __percpu_qual
+# define __percpu_qual
+#endif
+
+#endif /* __ASSEMBLER__ */
+#endif /* _ASM_GENERIC_PERCPU_TYPES_H_ */
--- a/include/linux/compiler_types.h
+++ b/include/linux/compiler_types.h
@@ -41,6 +41,7 @@
# define BTF_TYPE_TAG(value) /* nothing */
#endif
+#include <asm/percpu_types.h>
#include <linux/compiler-context-analysis.h>
/* sparse defines __CHECKER__; see Documentation/dev-tools/sparse.rst */
next prev parent reply other threads:[~2026-04-10 12:18 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 12:18 [patch 00/38] treewide: Cleanup LATCH, CLOCK_TICK_RATE and get_cycles() [ab]use Thomas Gleixner
2026-04-10 12:18 ` Thomas Gleixner [this message]
2026-04-10 12:18 ` [patch 02/38] x86: Cleanup include recursion hell Thomas Gleixner
2026-04-10 20:55 ` [patch V1.1 " Thomas Gleixner
2026-04-10 12:18 ` [patch 03/38] x86/apm: Remove last LATCH usage Thomas Gleixner
2026-04-10 12:18 ` [patch 04/38] x86: Use PIT_TICK_RATE instead of CLOCK_TICK_RATE Thomas Gleixner
2026-04-10 12:18 ` [patch 05/38] treewide: Remove CLOCK_TICK_RATE Thomas Gleixner
2026-04-15 6:40 ` Christophe Leroy (CS GROUP)
2026-04-16 11:22 ` Geert Uytterhoeven
2026-04-10 12:18 ` [patch 06/38] calibrate: Rework delay timer calibration Thomas Gleixner
2026-04-10 12:19 ` [patch 07/38] treewide: Consolidate cycles_t Thomas Gleixner
2026-04-13 9:15 ` Ojaswin Mujoo
2026-04-15 6:43 ` Christophe Leroy (CS GROUP)
2026-04-16 19:32 ` Thomas Gleixner
2026-04-16 11:22 ` Geert Uytterhoeven
2026-04-10 12:19 ` [patch 08/38] x86/tsc: Use rdtsc() instead of get_cycles() Thomas Gleixner
2026-04-10 12:19 ` [patch 09/38] iommu/vt-d: Use sched_clock() " Thomas Gleixner
2026-04-10 13:45 ` Baolu Lu
2026-04-10 15:14 ` Thomas Gleixner
2026-04-10 12:19 ` [patch 10/38] arcnet: Remove function timing code Thomas Gleixner
2026-04-13 15:29 ` David Woodhouse
2026-04-10 12:19 ` [patch 11/38] misc: sgi-gru: Remove get_cycles() [ab]use Thomas Gleixner
2026-04-10 20:56 ` [patch V1.1 " Thomas Gleixner
2026-04-10 12:19 ` [patch 12/38] wifi: wil6210: Replace get_cyles() usage Thomas Gleixner
2026-04-10 12:19 ` [patch 13/38] crypto: tcrypt: Replace get_cycles() with ktime_get() Thomas Gleixner
2026-04-10 12:19 ` [patch 14/38] slub: Use prandom instead of get_cycles() Thomas Gleixner
2026-04-10 12:19 ` [patch 15/38] ptp: ptp_vmclock: Replace get_cycles() usage Thomas Gleixner
2026-04-13 15:33 ` David Woodhouse
2026-04-13 19:30 ` Arnd Bergmann
2026-04-10 12:19 ` [patch 16/38] fbdev: udlfb: Replace get_cycles() with ktime_get() Thomas Gleixner
2026-04-10 12:19 ` [patch 17/38] ext4: Replace get_cycles() usage " Thomas Gleixner
2026-04-13 14:46 ` Arnd Bergmann
2026-04-10 12:19 ` [patch 18/38] lib/tests: Replace get_cycles() " Thomas Gleixner
2026-04-16 10:24 ` Geert Uytterhoeven
2026-04-10 12:20 ` [patch 19/38] kcsan: Replace get_cycles() usage Thomas Gleixner
2026-04-10 13:39 ` Marco Elver
2026-04-10 12:20 ` [patch 20/38] kasan: sw_tags: Replace get_cycles() by random_get_entropy() Thomas Gleixner
2026-04-10 12:20 ` [patch 21/38] hamradio: baycom_epp: Remove BAYCOM_DEBUG Thomas Gleixner
2026-04-10 12:20 ` [patch 22/38] random: Provide CONFIG_ARCH_HAS_RANDOM_ENTROPY Thomas Gleixner
2026-04-10 12:20 ` [patch 23/38] alpha: Select ARCH_HAS_RANDOM_ENTROPY Thomas Gleixner
2026-04-12 13:22 ` Magnus Lindholm
2026-04-10 12:20 ` [patch 24/38] ARM: " Thomas Gleixner
2026-04-10 12:20 ` [patch 25/38] arm64: " Thomas Gleixner
2026-04-10 12:20 ` [patch 26/38] loongarch: " Thomas Gleixner
2026-04-10 12:20 ` [patch 27/38] m68k: " Thomas Gleixner
2026-04-10 15:31 ` Daniel Palmer
2026-04-16 11:22 ` Geert Uytterhoeven
2026-04-10 12:20 ` [patch 28/38] mips: " Thomas Gleixner
2026-04-13 5:47 ` Maciej W. Rozycki
2026-04-10 12:20 ` [patch 29/38] nios2: " Thomas Gleixner
2026-04-10 12:20 ` [patch 30/38] openrisc: " Thomas Gleixner
2026-04-12 8:56 ` Stafford Horne
2026-04-10 12:21 ` [patch 31/38] parisc: " Thomas Gleixner
2026-04-14 12:41 ` Helge Deller
2026-04-10 12:21 ` [patch 32/38] powerpc/spufs: Use mftb() directly Thomas Gleixner
2026-04-13 14:43 ` Arnd Bergmann
2026-04-15 6:38 ` Christophe Leroy (CS GROUP)
2026-04-21 6:48 ` Mukesh Kumar Chaurasiya
2026-04-10 12:21 ` [patch 33/38] powerpc: Select ARCH_HAS_RANDOM_ENTROPY Thomas Gleixner
2026-04-15 6:47 ` Christophe Leroy (CS GROUP)
2026-04-21 11:22 ` Mukesh Kumar Chaurasiya
2026-04-10 12:21 ` [patch 34/38] riscv: " Thomas Gleixner
2026-04-10 12:21 ` [patch 35/38] s390: " Thomas Gleixner
2026-04-16 13:42 ` Heiko Carstens
2026-04-16 19:29 ` Thomas Gleixner
2026-04-10 12:21 ` [patch 36/38] sparc: Select ARCH_HAS_RANDOM_ENTROPY for SPARC64 Thomas Gleixner
2026-04-10 12:21 ` [patch 37/38] x86: Select ARCH_HAS_RANDOM_ENTROPY Thomas Gleixner
2026-04-10 12:21 ` [patch 38/38] treewide: Remove asm/timex.h includes from generic code Thomas Gleixner
2026-04-13 14:45 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260410120317.642797961@kernel.org \
--to=tglx@kernel$(echo .)org \
--cc=Jason@zx2c4$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=baolu.lu@linux$(echo .)intel.com \
--cc=bernie@plugable$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=dinguyen@kernel$(echo .)org \
--cc=dvyukov@google$(echo .)com \
--cc=dwmw2@infradead$(echo .)org \
--cc=elver@google$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=hca@linux$(echo .)ibm.com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=iommu@lists$(echo .)linux.dev \
--cc=jonas@southpole$(echo .)se \
--cc=kasan-dev@googlegroups$(echo .)com \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-ext4@vger$(echo .)kernel.org \
--cc=linux-fbdev@vger$(echo .)kernel.org \
--cc=linux-hams@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-openrisc@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=loongarch@lists$(echo .)linux.dev \
--cc=m.grzeschik@pengutronix$(echo .)de \
--cc=mpe@ellerman$(echo .)id.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pjw@kernel$(echo .)org \
--cc=richard.henderson@linaro$(echo .)org \
--cc=ryabinin.a.a@gmail$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=t.sailer@alumni$(echo .)ethz.ch \
--cc=tytso@mit$(echo .)edu \
--cc=urezki@gmail$(echo .)com \
--cc=vbabka@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox