Subject: Re: [PATCH 03/13] dt-bindings: thermal: add mt6323 PMIC thermal

From: Rob Herring <[email-masked]>
Date: Tue, 5 May 2026 09:05:21 -0500

On Mon, May 04, 2026 at 09:24:55PM +0300, Roman Vivchar wrote:
> The MediaTek mt6323 PMIC temperature can be read using AUXADC channel.
> 
> Add the devicetree binding documentation for the MediaTek mt6323 thermal.
> Due similarities with newer PMICs like mt6358, which include more than
> one thermal sensor, the #thermal-sensor-cells should be set to 1, to
> avoid breaking devicetree ABI in future.
> 
> Tested-by: Ben Grisdale <[email-masked]> # Amazon Echo Dot (2nd Generation)
> Signed-off-by: Roman Vivchar <[email-masked]>
> ---
>  .../bindings/thermal/mediatek,mt6323-thermal.yaml  | 63 ++++++++++++++++++++++
>  1 file changed, 63 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek,mt6323-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,mt6323-thermal.yaml
> new file mode 100644
> index 000000000000..1882816ba274
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek,mt6323-thermal.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/mediatek,mt6323-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek PMIC thermal
> +
> +maintainers:
> +  - Roman Vivchar <[email-masked]>
> +
> +description:
> +  The MediaTek PMIC thermal sensor uses an AUXADC channel to read raw
> +  temperature data and applies calibration data from NVMEM.
> +
> +allOf:
> +  - $ref: thermal-sensor.yaml#
> +
> +properties:
> +  compatible:
> +    const: mediatek,mt6323-thermal
> +
> +  io-channels:
> +    description: >

Don't need '>'.

> +      IIO channel for the AUXADC to read raw data from.
> +    maxItems: 1
> +
> +  io-channel-names:
> +    const: vts

-names properties are pointless for a single entry.

> +
> +  nvmem-cells:
> +    description: >
> +      NVMEM cell with phandle to the calibration data provided by the
> +      NVMEM device. If unspecified default values will be used.

Drop. Don't need generic descriptions.

> +    maxItems: 1
> +
> +  nvmem-cell-names:
> +    const: calibration-data
> +
> +  "#thermal-sensor-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - io-channels
> +  - io-channel-names
> +  - "#thermal-sensor-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/iio/adc/mediatek,mt6323-auxadc.h>
> +
> +    mt6323_thermal: thermal {

Drop unused labels.

> +      compatible = "mediatek,mt6323-thermal";
> +      nvmem-cells = <&mt6323_thermal_calibration_data>;
> +      nvmem-cell-names = "calibration-data";
> +
> +      io-channels = <&mt6323_adc MT6323_AUXADC_CHIP_TEMP>;
> +      io-channel-names = "vts";
> +      #thermal-sensor-cells = <1>;
> +    };
> 
> -- 
> 2.53.0
>