From: Rob Herring <robh@kernel•org>
To: Chen Wandun <chenwandun1@gmail•com>
Cc: kexec@lists•infradead.org, linux-doc@vger•kernel.org,
linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, loongarch@lists•linux.dev,
linux-riscv@lists•infradead.org, devicetree@vger•kernel.org,
akpm@linux-foundation•org, bhe@redhat•com, rppt@kernel•org,
pasha.tatashin@soleen•com, pratyush@kernel•org,
ruirui.yang@linux•dev, corbet@lwn•net, skhan@linuxfoundation•org,
catalin.marinas@arm•com, will@kernel•org, chenhuacai@kernel•org,
kernel@xen0n•name, pjw@kernel•org, palmer@dabbelt•com,
aou@eecs•berkeley.edu, saravanak@kernel•org,
chenwandun@lixiang•com, zhaomeijing@lixiang•com,
everyzhao@126•com
Subject: Re: [PATCH 01/11] of: reserved_mem: fix region count for nodes with multiple reg entries
Date: Tue, 5 May 2026 20:47:52 -0500 [thread overview]
Message-ID: <20260506014752.GA280279-robh@kernel.org> (raw)
In-Reply-To: <20260429065831.1510858-2-chenwandun@lixiang.com>
On Wed, Apr 29, 2026 at 02:58:21PM +0800, Chen Wandun wrote:
> When a reserved-memory node contains multiple reg entries (e.g.,
> reg = <base1 size1>, <base2 size2>), the count used for
> total_reserved_mem_cnt is wrong in two places:
>
> 1) __reserved_mem_reserve_reg() returns 0 on success regardless of how
> many regions it reserved in memblock. The caller in
> fdt_scan_reserved_mem() then increments count by just 1.
Just to make sure, more than 1 worked before the referenced commits? It
would be easier to just define we only expect/support 1 entry.
>
> 2) fdt_scan_reserved_mem_late() uses of_flat_dt_get_addr_size() which
> only reads the first reg entry. Subsequent entries are never
> initialized via fdt_init_reserved_mem_node(), so their metadata is
> lost.
>
> Fix both issues:
> - Make __reserved_mem_reserve_reg() return the actual number of
> regions successfully reserved. Update the caller to accumulate
> the returned count.
> - Rewrite fdt_scan_reserved_mem_late() to use
> of_flat_dt_get_addr_size_prop() and iterate all reg entries,
> initializing each one via fdt_init_reserved_mem_node().
>
> Fixes: 8a6e02d0c00e ("of: reserved_mem: Restructure how the reserved memory regions are processed")
> Fixes: 00c9a452a235 ("of: reserved_mem: Add code to dynamically allocate reserved_mem array")
next prev parent reply other threads:[~2026-05-06 1:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 6:58 [PATCH 00/11] kdump: reduce vmcore size and capture time via linux,no-dump Chen Wandun
2026-04-29 6:58 ` [PATCH 01/11] of: reserved_mem: fix region count for nodes with multiple reg entries Chen Wandun
2026-05-06 1:47 ` Rob Herring [this message]
2026-05-07 8:41 ` Wandun
2026-04-29 6:58 ` [PATCH 02/11] of: reserved_mem: reject reserved memory outside physical address range Chen Wandun
2026-05-06 1:51 ` Rob Herring
2026-05-07 9:35 ` Wandun
2026-04-29 6:58 ` [PATCH 03/11] of: reserved_mem: avoid unconditional save of reg entries in fdt_scan_reserved_mem_late() Chen Wandun
2026-04-29 6:58 ` [PATCH 04/11] of: reserved_mem: skip reserved_mem array allocation when there is nothing to save Chen Wandun
2026-04-29 6:58 ` [PATCH 05/11] of: reserved_mem: add linux,no-dump property support for reserved memory regions Chen Wandun
2026-05-06 14:45 ` Rob Herring
2026-05-07 9:41 ` Wandun
2026-04-29 6:58 ` [PATCH 06/11] of: reserved_mem: save /memreserve/ entries into reserved_mem array Chen Wandun
2026-04-29 6:58 ` [PATCH 07/11] of: reserved_mem: add no-dump crash_mem exclusion helpers Chen Wandun
2026-05-06 14:50 ` Rob Herring
2026-05-07 8:48 ` Wandun
2026-04-29 6:58 ` [PATCH 08/11] arm64: kdump: exclude no-dump reserved memory regions from vmcore Chen Wandun
2026-04-29 6:58 ` [PATCH 09/11] riscv: " Chen Wandun
2026-04-29 6:58 ` [PATCH 10/11] loongarch: " Chen Wandun
2026-04-29 6:58 ` [PATCH 11/11] Documentation: admin-guide: kdump: document linux,no-dump DT property Chen Wandun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506014752.GA280279-robh@kernel.org \
--to=robh@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=bhe@redhat$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=chenwandun1@gmail$(echo .)com \
--cc=chenwandun@lixiang$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=everyzhao@126$(echo .)com \
--cc=kernel@xen0n$(echo .)name \
--cc=kexec@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=loongarch@lists$(echo .)linux.dev \
--cc=palmer@dabbelt$(echo .)com \
--cc=pasha.tatashin@soleen$(echo .)com \
--cc=pjw@kernel$(echo .)org \
--cc=pratyush@kernel$(echo .)org \
--cc=rppt@kernel$(echo .)org \
--cc=ruirui.yang@linux$(echo .)dev \
--cc=saravanak@kernel$(echo .)org \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=zhaomeijing@lixiang$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox