Subject: Re: [PATCH] crypto: atmel-ecc - replace min_t with min

From: David Laight <[email-masked]>
Date: Thu, 7 May 2026 15:50:04 +0100

On Thu,  7 May 2026 15:55:27 +0200
Thorsten Blum <[email-masked]> wrote:

> Use the simpler min() macro since the values are all unsigned and
> compatible.
> 
> Signed-off-by: Thorsten Blum <[email-masked]>

I'm all for nuking min_t(), so:

Reviewed-by: David Laight <[email-masked]>

> ---
>  drivers/crypto/atmel-ecc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
> index b6a77c8d439c..2cf53f0b6742 100644
> --- a/drivers/crypto/atmel-ecc.c
> +++ b/drivers/crypto/atmel-ecc.c
> @@ -56,7 +56,7 @@ static void atmel_ecdh_done(struct atmel_i2c_work_data *work_data, void *areq,
>  		goto free_work_data;
>  
>  	/* might want less than we've got */
> -	n_sz = min_t(size_t, ATMEL_ECC_NIST_P256_N_SIZE, req->dst_len);
> +	n_sz = min(ATMEL_ECC_NIST_P256_N_SIZE, req->dst_len);

Not entirely related, but (to me) the arguments are in the wrong order.

>  
>  	/* copy the shared secret */
>  	copied = sg_copy_from_buffer(req->dst, sg_nents_for_len(req->dst, n_sz),
> @@ -150,7 +150,7 @@ static int atmel_ecdh_generate_public_key(struct kpp_request *req)
>  		return -EINVAL;
>  
>  	/* might want less than we've got */
> -	nbytes = min_t(size_t, ATMEL_ECC_PUBKEY_SIZE, req->dst_len);
> +	nbytes = min(ATMEL_ECC_PUBKEY_SIZE, req->dst_len);
>  
>  	/* public key was saved at private key generation */
>  	copied = sg_copy_from_buffer(req->dst,
>