From: Jonathan Cameron <jic23@kernel•org>
To: Maxwell Doose <m32285159@gmail•com>
Cc: "Sanjay Chitroda" <sanjayembeddedse@gmail•com>,
salih.erim@amd•com, conall.ogriofa@amd•com, michal.simek@amd•com,
"David Lechner" <dlechner@baylibre•com>,
"Nuno Sá" <nuno.sa@analog•com>,
"Andy Shevchenko" <andy@kernel•org>,
linux-iio@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2] iio: adc: xilinx-ams: Replace spin_lock() and unlock() calls with guard(spinlock*)()
Date: Mon, 11 May 2026 18:21:01 +0100 [thread overview]
Message-ID: <20260511182101.705a5c1c@jic23-huawei> (raw)
In-Reply-To: <CAKqfh0Hmchpq5zvK6Fd=VCqWXN+1FKyWxNyF1O=3zsVEM7HJUw@mail.gmail.com>
On Fri, 8 May 2026 13:53:11 -0500
Maxwell Doose <m32285159@gmail•com> wrote:
> On Fri, May 8, 2026 at 1:50 PM Sanjay Chitroda
> <sanjayembeddedse@gmail•com> wrote:
> >
> > Hi Maxwell,
> >
> > Thanks for the resource cleanup change.
> >
> > Overall looks good.
> >
> > Also, there is opportunity for guard(mutex)().
> >
>
> Thanks, of course I'd also be happy to do the transition to
> guard(mutex)() but it seems like something for tomorrow evening since
> I've already submitted a lot to the mailing list.
Nice patch and well noted by Sanjay - I'd have just applied this
without checking for that :) I think sensible to do one patch that
deals with guard() for both mutex and spinlock.
Sometimes the Xilinx folk do review so I'll leave this a while longer
anyway in the hope they have time to take a look.
It's a safe change set but none the less nice to give time!
Thanks,
Jonathan
>
> best regards,
> max
>
>
>
>
> >
> > Thanks,
> > Sanjay Chitroda
> >
> >
next prev parent reply other threads:[~2026-05-11 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 12:45 [PATCH v2] iio: adc: xilinx-ams: Replace spin_lock() and unlock() calls with guard(spinlock*)() Maxwell Doose
2026-05-08 18:49 ` Sanjay Chitroda
2026-05-08 18:53 ` Maxwell Doose
2026-05-11 17:21 ` Jonathan Cameron [this message]
2026-05-10 9:24 ` Andy Shevchenko
2026-05-14 1:33 ` Salih Erim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511182101.705a5c1c@jic23-huawei \
--to=jic23@kernel$(echo .)org \
--cc=andy@kernel$(echo .)org \
--cc=conall.ogriofa@amd$(echo .)com \
--cc=dlechner@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=m32285159@gmail$(echo .)com \
--cc=michal.simek@amd$(echo .)com \
--cc=nuno.sa@analog$(echo .)com \
--cc=salih.erim@amd$(echo .)com \
--cc=sanjayembeddedse@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox