From: Leo Yan <leo.yan@arm•com>
To: James Clark <james.clark@linaro•org>
Cc: John Garry <john.g.garry@oracle•com>,
Will Deacon <will@kernel•org>, Mike Leach <mike.leach@linaro•org>,
Leo Yan <leo.yan@linux•dev>,
Peter Zijlstra <peterz@infradead•org>,
Ingo Molnar <mingo@redhat•com>,
Arnaldo Carvalho de Melo <acme@kernel•org>,
Namhyung Kim <namhyung@kernel•org>,
Mark Rutland <mark.rutland@arm•com>,
Alexander Shishkin <alexander.shishkin@linux•intel.com>,
Jiri Olsa <jolsa@kernel•org>, Ian Rogers <irogers@google•com>,
Adrian Hunter <adrian.hunter@intel•com>,
linux-arm-kernel@lists•infradead.org,
linux-perf-users@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] perf arm-spe: Don't warn about the discard bit if it doesn't exist
Date: Wed, 13 May 2026 11:20:24 +0100 [thread overview]
Message-ID: <20260513102024.GE34802@e132581.arm.com> (raw)
In-Reply-To: <20260410-james-spe-discard-warning-v1-1-985c02756ee4@linaro.org>
On Fri, Apr 10, 2026 at 12:05:12PM +0100, James Clark wrote:
> Opening an SPE event shows a warning that doesn't concern the user:
>
> $ perf record -e arm_spe
> Unknown/empty format name: discard
>
> Perf only wants to know if the discard bit is set for configuring the
> event, not in response to anything the user has done. Fix it by adding
> another helper that returns if a config bit exists without warning.
>
> We should probably keep the warning in evsel__get_config_val() to avoid
> having every caller having to do it, and most format bits should never
> be missing.
>
> Add a test for the new helper. Rename the parent test function to be
> more generic rather than adding a new one as it requires a lot of
> boilerplate.
>
> Signed-off-by: James Clark <james.clark@linaro•org>
Reviewed-by: Leo Yan <leo.yan@arm•com>
next prev parent reply other threads:[~2026-05-13 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 11:05 [PATCH] perf arm-spe: Don't warn about the discard bit if it doesn't exist James Clark
2026-05-13 10:20 ` Leo Yan [this message]
2026-05-13 12:55 ` Ian Rogers
2026-05-29 9:42 ` James Clark
2026-05-30 0:21 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513102024.GE34802@e132581.arm.com \
--to=leo.yan@arm$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=adrian.hunter@intel$(echo .)com \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=irogers@google$(echo .)com \
--cc=james.clark@linaro$(echo .)org \
--cc=john.g.garry@oracle$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=leo.yan@linux$(echo .)dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mike.leach@linaro$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox