From: Jason Gunthorpe <jgg@nvidia•com>
To: Nicolin Chen <nicolinc@nvidia•com>
Cc: iommu@lists•linux.dev, Jonathan Hunter <jonathanh@nvidia•com>,
Joerg Roedel <joro@8bytes•org>,
linux-arm-kernel@lists•infradead.org,
linux-tegra@vger•kernel.org, Robin Murphy <robin.murphy@arm•com>,
Thierry Reding <thierry.reding@kernel•org>,
Krishna Reddy <vdumpa@nvidia•com>, Will Deacon <will@kernel•org>,
David Matlack <dmatlack@google•com>,
Pasha Tatashin <pasha.tatashin@soleen•com>,
patches@lists•linux.dev, Pranjal Shrivastava <praan@google•com>,
Samiullah Khawaja <skhawaja@google•com>,
Mostafa Saleh <smostafa@google•com>
Subject: Re: [PATCH v2 3/9] iommu/arm-smmu-v3: Use the HW arm_smmu_cmd in cmdq submission functions
Date: Fri, 15 May 2026 19:00:32 -0300 [thread overview]
Message-ID: <20260515220032.GK787748@nvidia.com> (raw)
In-Reply-To: <ageKAQC7yAzI0xB6@Asurada-Nvidia>
On Fri, May 15, 2026 at 02:02:57PM -0700, Nicolin Chen wrote:
> On Wed, May 13, 2026 at 08:57:42PM -0300, Jason Gunthorpe wrote:
> > Continue removing struct arm_smmu_cmdq_ent in favour of the HW based
> > struct arm_smmu_cmd. Switch the lower level issue commands to work on
> > the native struct by lifting arm_smmu_cmdq_build_cmd() into all the
> > callers.
> >
> > Following patches will revise each of the arm_smmu_cmdq_build_cmd()
> > call sites to replace it with the HW struct.
> >
> > Reviewed-by: Mostafa Saleh <smostafa@google•com>
> > Reviewed-by: Pranjal Shrivastava <praan@google•com>
> > Tested-by: Pranjal Shrivastava <praan@google•com>
> > Tested-by: Mostafa Saleh <smostafa@google•com>
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia•com>
> [...]
> > @@ -3446,6 +3447,7 @@ arm_smmu_install_new_domain_invs(struct arm_smmu_attach_state *state)
> > static void arm_smmu_inv_flush_iotlb_tag(struct arm_smmu_inv *inv)
> > {
> > struct arm_smmu_cmdq_ent cmd = {};
> > + struct arm_smmu_cmd hw_cmd;
>
> Following the other pattern, this could be:
> "cmd" -> "ent" and "hw_cmd" -> "cmd"?
>
> That being said, at the end of the series, these all get removed.
Yeah, I made choices to minimize the diffs
Jason
next prev parent reply other threads:[~2026-05-15 22:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 23:57 [PATCH v2 0/9] Remove SMMUv3 struct arm_smmu_cmdq_ent Jason Gunthorpe
2026-05-13 23:57 ` [PATCH v2 1/9] iommu/arm-smmu-v3: Add struct arm_smmu_cmd to represent the HW format command Jason Gunthorpe
2026-05-13 23:57 ` [PATCH v2 2/9] iommu/arm-smmu-v3: Use the HW arm_smmu_cmd in cmdq selection functions Jason Gunthorpe
2026-05-15 20:31 ` Nicolin Chen
2026-05-13 23:57 ` [PATCH v2 3/9] iommu/arm-smmu-v3: Use the HW arm_smmu_cmd in cmdq submission functions Jason Gunthorpe
2026-05-15 21:02 ` Nicolin Chen
2026-05-15 22:00 ` Jason Gunthorpe [this message]
2026-05-13 23:57 ` [PATCH v2 4/9] iommu/arm-smmu-v3: Convert arm_smmu_cmdq_batch cmds to struct arm_smmu_cmd Jason Gunthorpe
2026-05-15 23:29 ` Nicolin Chen
2026-05-13 23:57 ` [PATCH v2 5/9] iommu/arm-smmu-v3: Remove CMDQ_OP_CFGI_CD_ALL from arm_smmu_cmdq_build_cmd() Jason Gunthorpe
2026-05-15 23:51 ` Nicolin Chen
2026-05-13 23:57 ` [PATCH v2 6/9] iommu/arm-smmu-v3: Directly encode simple commands Jason Gunthorpe
2026-05-18 3:15 ` Nicolin Chen
2026-05-18 13:23 ` Jason Gunthorpe
2026-05-13 23:57 ` [PATCH v2 7/9] iommu/arm-smmu-v3: Directly encode CMDQ_OP_ATC_INV Jason Gunthorpe
2026-05-18 3:27 ` Nicolin Chen
2026-05-18 14:40 ` Jason Gunthorpe
2026-05-13 23:57 ` [PATCH v2 8/9] iommu/arm-smmu-v3: Directly encode CMDQ_OP_SYNC Jason Gunthorpe
2026-05-18 3:30 ` Nicolin Chen
2026-05-13 23:57 ` [PATCH v2 9/9] iommu/arm-smmu-v3: Directly encode TLBI commands Jason Gunthorpe
2026-05-18 3:52 ` Nicolin Chen
2026-05-15 3:35 ` [PATCH v2 0/9] Remove SMMUv3 struct arm_smmu_cmdq_ent Nicolin Chen
2026-05-16 0:46 ` Samiullah Khawaja
2026-05-19 15:22 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515220032.GK787748@nvidia.com \
--to=jgg@nvidia$(echo .)com \
--cc=dmatlack@google$(echo .)com \
--cc=iommu@lists$(echo .)linux.dev \
--cc=jonathanh@nvidia$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=nicolinc@nvidia$(echo .)com \
--cc=pasha.tatashin@soleen$(echo .)com \
--cc=patches@lists$(echo .)linux.dev \
--cc=praan@google$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=skhawaja@google$(echo .)com \
--cc=smostafa@google$(echo .)com \
--cc=thierry.reding@kernel$(echo .)org \
--cc=vdumpa@nvidia$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox