From: Conor Dooley <conor@kernel•org>
To: Damon Ding <damon.ding@rock-chips•com>
Cc: Conor Dooley <conor.dooley@microchip•com>,
hjc@rock-chips•com, heiko@sntech•de, andy.yan@rock-chips•com,
maarten.lankhorst@linux•intel.com, mripard@kernel•org,
tzimmermann@suse•de, airlied@gmail•com, simona@ffwll•ch,
robh@kernel•org, krzk+dt@kernel•org, conor+dt@kernel•org,
andrzej.hajda@intel•com, neil.armstrong@linaro•org,
rfoss@kernel•org, Laurent.pinchart@ideasonboard•com,
jonas@kwiboo•se, jernej.skrabec@gmail•com,
nicolas.frattaroli@collabora•com,
cristian.ciocaltea@collabora•com,
sebastian.reichel@collabora•com,
dmitry.baryshkov@oss•qualcomm.com, luca.ceresoli@bootlin•com,
dianders@chromium•org, m.szyprowski@samsung•com,
dri-devel@lists•freedesktop.org, devicetree@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-rockchip@lists•infradead.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: display: rockchip: analogix-dp: Expose inherited properties
Date: Mon, 18 May 2026 17:31:14 +0100 [thread overview]
Message-ID: <20260518-bootlace-afoot-8da24d7c9d13@spud> (raw)
In-Reply-To: <a7ab01f6-78a4-405f-8160-8af31a8ef99c@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 3963 bytes --]
On Mon, May 18, 2026 at 10:44:29AM +0800, Damon Ding wrote:
> Hi Conor,
>
> On 5/15/2026 5:04 PM, Conor Dooley wrote:
> > On Fri, May 15, 2026 at 11:57:58AM +0800, Damon Ding wrote:
> > > Hi Conor,
> > >
> > > On 5/15/2026 2:16 AM, Conor Dooley wrote:
> > > > On Thu, May 14, 2026 at 03:01:31PM +0800, Damon Ding wrote:
> > > > > Expose the inherited properties from the base analogix-dp schema
> > > > > to satisfy unevaluatedProperties constraints.
> > > > >
> > > > > Signed-off-by: Damon Ding <damon.ding@rock-chips•com>
> > > >
> > > > Given it's unevaluatedProperties, not addtionalProperties, this patch
> > > > shouldn't be needed?
> > > >
> > >
> > > When I remove both the top-level data-lanes property and those explicit
> > > "xxx: true" property entries and run the dtbs check with:
> > >
> > > make CHECK_DTBS=y CROSS_COMPILE=aarch64-linux-gnu- LT0=none LLVM=1
> > > LLVM_IAS=1 ARCH=arm64 rockchip/rk3588-evb1-v10.dtb
> > > rockchip/rk3588s-evb1-v10.dtb rockchip/rk3399-sapphire-excavator.dtb
> > > rockchip/rk3576-evb1-v10.dtb -j4
> > >
> > > It results in validation errors like these:
> > >
> > > /home/ding/drm-misc/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dtb:
> > > edp@27dc0000: ports:port@1:endpoint: Unevaluated properties are not allowed
> > > ('data-lanes' was unexpected)
> > > from schema $id:
> > > http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml#
> > > /home/ding/drm-misc/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dtb:
> > > edp@27dc0000: Unevaluated properties are not allowed ('force-hpd',
> > > 'interrupts', 'phy-names', 'phys', 'ports', 'reg' were unexpected)
> > > from schema $id:
> > > http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml#
> > >
> > > I suspect that the properties defined in the child binding are
> > > overriding/masking all the inherited properties from the parent Analogix DP
> > > schema.
> > >
> > > Is there a better way to fix this issue without explicitly listing all
> > > inherited properties as true?
> >
> > The example in this file uses most of the properties that you mention
> > above:
> > dp@ff970000 {
> > compatible = "rockchip,rk3288-dp";
> > reg = <0xff970000 0x4000>;
> > interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&cru SCLK_EDP>, <&cru PCLK_EDP_CTRL>;
> > clock-names = "dp", "pclk";
> > phys = <&dp_phy>;
> > phy-names = "dp";
> > resets = <&cru 111>;
> > reset-names = "dp";
> > rockchip,grf = <&grf>;
> > pinctrl-0 = <&edp_hpd>;
> > pinctrl-names = "default";
> >
> > dt_binding_check reports no problems with this node, so I think the
> > problem might lie elsewhere?
> > There's no edp node in the dts you mention above, so this looks like an
> > interaction with something that's not yet upstream.
>
> Ah, I see.
>
> I did add extra changes to the edp node on my local rk3576-evb1 board DTS,
> which indeed caused this 'asymmetric information' issue and made the
> validation fail incorrectly.
>
> I will try adding the data-lanes property to the example in the binding
> document to ensure dt_binding_check passes cleanly.
>
> >
> > If this is required for the rk3576 edp, then you should include this
> > patch in the rk3576 edp support series rather than this one anyway where
> > it can actually be evaluated alongside the node it apparently causes
> > problems with.
>
> The data-lanes property is actually applicable and useful for all Rockchip
> eDP platforms, not just rk3576.
>
> In the next version, I will modify the series to better separate this common
> data-lanes change from the rk3576 specific eDP support patches.
To be clear, I wasn't talking about data-lanes here, I was talking about
this patch that addressed the properties inherited from the common
analogix-dp.yaml.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-05-18 16:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 7:01 [PATCH v1 0/3] Add eDP lane mapping support Damon Ding
2026-05-14 7:01 ` [PATCH v1 1/3] dt-bindings: display: rockchip: analogix-dp: Expose inherited properties Damon Ding
2026-05-14 18:16 ` Conor Dooley
2026-05-15 3:57 ` Damon Ding
2026-05-15 9:04 ` Conor Dooley
2026-05-18 2:44 ` Damon Ding
2026-05-18 16:31 ` Conor Dooley [this message]
2026-05-14 7:01 ` [PATCH v1 2/3] dt-bindings: display: bridge: analogix-dp: Add data-lanes support for endpoint Damon Ding
2026-05-14 18:19 ` Conor Dooley
2026-05-15 2:53 ` Damon Ding
2026-05-14 7:01 ` [PATCH v1 3/3] drm/bridge: analogix_dp: Add support for optional data-lanes mapping Damon Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518-bootlace-afoot-8da24d7c9d13@spud \
--to=conor@kernel$(echo .)org \
--cc=Laurent.pinchart@ideasonboard$(echo .)com \
--cc=airlied@gmail$(echo .)com \
--cc=andrzej.hajda@intel$(echo .)com \
--cc=andy.yan@rock-chips$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=conor.dooley@microchip$(echo .)com \
--cc=cristian.ciocaltea@collabora$(echo .)com \
--cc=damon.ding@rock-chips$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dianders@chromium$(echo .)org \
--cc=dmitry.baryshkov@oss$(echo .)qualcomm.com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=heiko@sntech$(echo .)de \
--cc=hjc@rock-chips$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jonas@kwiboo$(echo .)se \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=luca.ceresoli@bootlin$(echo .)com \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=mripard@kernel$(echo .)org \
--cc=neil.armstrong@linaro$(echo .)org \
--cc=nicolas.frattaroli@collabora$(echo .)com \
--cc=rfoss@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=sebastian.reichel@collabora$(echo .)com \
--cc=simona@ffwll$(echo .)ch \
--cc=tzimmermann@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox