Subject: Re: [PATCH v2 7/9] iommu/arm-smmu-v3: Directly encode CMDQ_OP_ATC_INV

From: Jason Gunthorpe <[email-masked]>
Date: Mon, 18 May 2026 11:40:31 -0300

On Sun, May 17, 2026 at 08:27:40PM -0700, Nicolin Chen wrote:
> > -	*cmd = (struct arm_smmu_cmdq_ent) {
> > -		.opcode			= CMDQ_OP_ATC_INV,
> > -		.substream_valid	= (ssid != IOMMU_NO_PASID),
> > -		.atc.ssid		= ssid,
> > -	};
> > -
> > -	if (!size) {
> > -		cmd->atc.size = ATC_INV_SIZE_ALL;
> > -		return;
> > -	}
> 
> .. should !size jump to arm_smmu_make_cmd_atc_inv_all()?

I audited it, there are no !sizes anymore and there is only one caller
that never does full invalidation

Jason