From: Marc Zyngier <maz@kernel•org>
To: kvmarm@lists•linux.dev, linux-arm-kernel@lists•infradead.org
Cc: Deepanshu Kartikey <kartikey406@gmail•com>,
Steffen Eiden <seiden@linux•ibm.com>,
Joey Gouly <joey.gouly@arm•com>,
Suzuki K Poulose <suzuki.poulose@arm•com>,
Oliver Upton <oupton@kernel•org>,
Zenghui Yu <yuzenghui@huawei•com>
Subject: [PATCH v3 4/6] KVM: arm64: pmu: Kill the PMU interrupt level cache
Date: Wed, 20 May 2026 11:01:58 +0100 [thread overview]
Message-ID: <20260520100200.543845-5-maz@kernel.org> (raw)
In-Reply-To: <20260520100200.543845-1-maz@kernel.org>
Just like the timer, the PMU has an interrupt cache that serves little
purpose. Drop it.
Signed-off-by: Marc Zyngier <maz@kernel•org>
---
arch/arm64/kvm/pmu-emul.c | 13 +++----------
include/kvm/arm_pmu.h | 1 -
2 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/arch/arm64/kvm/pmu-emul.c b/arch/arm64/kvm/pmu-emul.c
index 31a472a2c4881..edb21239478a9 100644
--- a/arch/arm64/kvm/pmu-emul.c
+++ b/arch/arm64/kvm/pmu-emul.c
@@ -396,19 +396,12 @@ static bool kvm_pmu_overflow_status(struct kvm_vcpu *vcpu)
static void kvm_pmu_update_state(struct kvm_vcpu *vcpu)
{
struct kvm_pmu *pmu = &vcpu->arch.pmu;
- bool overflow;
- overflow = kvm_pmu_overflow_status(vcpu);
- if (pmu->irq_level == overflow)
+ if (unlikely(!irqchip_in_kernel(vcpu->kvm)))
return;
- pmu->irq_level = overflow;
-
- if (likely(irqchip_in_kernel(vcpu->kvm))) {
- int ret = kvm_vgic_inject_irq(vcpu->kvm, vcpu,
- pmu->irq_num, overflow, pmu);
- WARN_ON(ret);
- }
+ WARN_ON(kvm_vgic_inject_irq(vcpu->kvm, vcpu, pmu->irq_num,
+ kvm_pmu_overflow_status(vcpu), pmu));
}
bool kvm_pmu_should_notify_user(struct kvm_vcpu *vcpu)
diff --git a/include/kvm/arm_pmu.h b/include/kvm/arm_pmu.h
index 3e844c5ee9174..b5e5942204fc6 100644
--- a/include/kvm/arm_pmu.h
+++ b/include/kvm/arm_pmu.h
@@ -32,7 +32,6 @@ struct kvm_pmu {
struct kvm_pmc pmc[KVM_ARMV8_PMU_MAX_COUNTERS];
int irq_num;
bool created;
- bool irq_level;
};
struct arm_pmu_entry {
--
2.47.3
next prev parent reply other threads:[~2026-05-20 10:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 10:01 [PATCH v3 0/6] KVM: arm64: Don't perform vgic-v2 lazy init on timer injection Marc Zyngier
2026-05-20 10:01 ` [PATCH v3 1/6] KVM: arm64: timer: Repaint kvm_timer_{should,irq_can}_fire() to kvm_timer_{pending,enabled}() Marc Zyngier
2026-05-20 10:01 ` [PATCH v3 2/6] KVM: arm64: Simplify userspace notification of interrupt state Marc Zyngier
2026-05-20 10:01 ` [PATCH v3 3/6] KVM: arm64: timer: Kill the per-timer irq level cache Marc Zyngier
2026-05-20 10:01 ` Marc Zyngier [this message]
2026-05-20 10:01 ` [PATCH v3 5/6] KVM: arm64: vgic-v2: Force vgic init on injection outside the run loop Marc Zyngier
2026-05-20 10:02 ` [PATCH v3 6/6] KVM: arm64: vgic-v2: Don't init the vgic on in-kernel interrupt injection Marc Zyngier
2026-05-20 18:26 ` [PATCH v3 0/6] KVM: arm64: Don't perform vgic-v2 lazy init on timer injection Oliver Upton
2026-05-21 7:23 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520100200.543845-5-maz@kernel.org \
--to=maz@kernel$(echo .)org \
--cc=joey.gouly@arm$(echo .)com \
--cc=kartikey406@gmail$(echo .)com \
--cc=kvmarm@lists$(echo .)linux.dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=oupton@kernel$(echo .)org \
--cc=seiden@linux$(echo .)ibm.com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=yuzenghui@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox