From: Mithil Bavishi <bavishimithil@gmail•com>
To: Aaro Koskinen <aaro.koskinen@iki•fi>,
Andreas Kemnade <andreas@kemnade•info>,
Kevin Hilman <khilman@baylibre•com>,
Roger Quadros <rogerq@kernel•org>,
Tony Lindgren <tony@atomide•com>,
Russell King <linux@armlinux•org.uk>
Cc: Sami Tolvanen <samitolvanen@google•com>,
Kees Cook <kees@kernel•org>,
Nathan Chancellor <nathan@kernel•org>,
linux-arm-kernel@lists•infradead.org, linux-omap@vger•kernel.org,
llvm@lists•linux.dev, linux-kernel@vger•kernel.org,
Mithil Bavishi <bavishimithil@gmail•com>
Subject: [PATCH v2] ARM: OMAP2+: Add CFI type for omap4_finish_suspend
Date: Fri, 22 May 2026 16:30:36 -0700 [thread overview]
Message-ID: <20260522233036.12277-1-bavishimithil@gmail.com> (raw)
With CONFIG_CFI enabled, OMAP4 can trap in omap4_enter_lowpower()
because omap_pm_ops.finish_suspend points directly to the assembly
routine omap4_finish_suspend, which lacks the expected KCFI type
metadata.
Annotate omap4_finish_suspend with SYM_TYPED_FUNC_START so the assembly
routine carries the KCFI type metadata.
Signed-off-by: Mithil Bavishi <bavishimithil@gmail•com>
---
arch/arm/mach-omap2/sleep44xx.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/sleep44xx.S b/arch/arm/mach-omap2/sleep44xx.S
index f09c91978..0b48df6fc 100644
--- a/arch/arm/mach-omap2/sleep44xx.S
+++ b/arch/arm/mach-omap2/sleep44xx.S
@@ -58,7 +58,7 @@
* stack frame and it expects the caller to take care of it. Hence the entire
* stack frame is saved to avoid possible stack corruption.
*/
-ENTRY(omap4_finish_suspend)
+SYM_TYPED_FUNC_START(omap4_finish_suspend)
stmfd sp!, {r4-r12, lr}
cmp r0, #0x0
beq do_WFI @ No lowpower state, jump to WFI
@@ -223,7 +223,7 @@ skip_scu_gp_clear:
isb
dsb
ldmfd sp!, {r4-r12, pc}
-ENDPROC(omap4_finish_suspend)
+SYM_FUNC_END(omap4_finish_suspend)
/*
* ============================
--
2.43.0
next reply other threads:[~2026-05-22 23:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 23:30 Mithil Bavishi [this message]
2026-05-23 1:17 ` [PATCH v2] ARM: OMAP2+: Add CFI type for omap4_finish_suspend Nathan Chancellor
2026-05-23 22:04 ` Andreas Kemnade
2026-05-24 6:01 ` kernel test robot
2026-05-25 16:55 ` Nathan Chancellor
2026-06-04 5:43 ` Mithil Bavishi
2026-05-25 15:18 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260522233036.12277-1-bavishimithil@gmail.com \
--to=bavishimithil@gmail$(echo .)com \
--cc=aaro.koskinen@iki$(echo .)fi \
--cc=andreas@kemnade$(echo .)info \
--cc=kees@kernel$(echo .)org \
--cc=khilman@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=llvm@lists$(echo .)linux.dev \
--cc=nathan@kernel$(echo .)org \
--cc=rogerq@kernel$(echo .)org \
--cc=samitolvanen@google$(echo .)com \
--cc=tony@atomide$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox