From: Mostafa Saleh <smostafa@google•com>
To: op-tee@lists•trustedfirmware.org, linux-kernel@vger•kernel.org,
kvmarm@lists•linux.dev, linux-arm-kernel@lists•infradead.org
Cc: maz@kernel•org, oupton@kernel•org, joey.gouly@arm•com,
suzuki.poulose@arm•com, catalin.marinas@arm•com,
jens.wiklander@linaro•org, sumit.garg@kernel•org,
sebastianene@google•com, vdonnefort@google•com,
sudeep.holla@kernel•org, Mostafa Saleh <smostafa@google•com>
Subject: [PATCH v5 1/6] optee: ffa: Add NULL check in optee_ffa_lend_protmem
Date: Tue, 26 May 2026 15:19:29 +0000 [thread overview]
Message-ID: <20260526151934.3783707-2-smostafa@google.com> (raw)
In-Reply-To: <20260526151934.3783707-1-smostafa@google.com>
Sashiko (locally) reports a possible null dereference under memory
pressure due to the lack of validation of the allocated pointer.
Fix that by adding the missing check.
Signed-off-by: Mostafa Saleh <smostafa@google•com>
---
drivers/tee/optee/ffa_abi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c
index b4372fa268d0..633715b98625 100644
--- a/drivers/tee/optee/ffa_abi.c
+++ b/drivers/tee/optee/ffa_abi.c
@@ -698,6 +698,9 @@ static int optee_ffa_lend_protmem(struct optee *optee, struct tee_shm *protmem,
int rc;
mem_attr = kzalloc_objs(*mem_attr, ma_count);
+ if (!mem_attr)
+ return -ENOMEM;
+
for (n = 0; n < ma_count; n++) {
mem_attr[n].receiver = mem_attrs[n] & U16_MAX;
mem_attr[n].attrs = mem_attrs[n] >> 16;
--
2.54.0.746.g67dd491aae-goog
next prev parent reply other threads:[~2026-05-26 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 15:19 [PATCH v5 0/6] arm_ffa, KVM: Fix FF-A emad offset calculations Mostafa Saleh
2026-05-26 15:19 ` Mostafa Saleh [this message]
2026-05-26 15:19 ` [PATCH v5 2/6] firmware: arm_ffa: Fix out-of-bound writes in ffa_setup_and_transmit() Mostafa Saleh
2026-05-26 15:19 ` [PATCH v5 3/6] firmware: arm_ffa: Fix Endpoint Memory Access Descriptor offset calculation Mostafa Saleh
2026-05-26 15:19 ` [PATCH v5 4/6] KVM: arm64: Fix bounds checking in do_ffa_mem_reclaim() Mostafa Saleh
2026-05-26 15:19 ` [PATCH v5 5/6] KVM: arm64: Validate the offset to the mem access descriptor Mostafa Saleh
2026-05-26 15:19 ` [PATCH v5 6/6] KVM: arm64: Ensure FFA ranges are page aligned Mostafa Saleh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260526151934.3783707-2-smostafa@google.com \
--to=smostafa@google$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=jens.wiklander@linaro$(echo .)org \
--cc=joey.gouly@arm$(echo .)com \
--cc=kvmarm@lists$(echo .)linux.dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=maz@kernel$(echo .)org \
--cc=op-tee@lists$(echo .)trustedfirmware.org \
--cc=oupton@kernel$(echo .)org \
--cc=sebastianene@google$(echo .)com \
--cc=sudeep.holla@kernel$(echo .)org \
--cc=sumit.garg@kernel$(echo .)org \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=vdonnefort@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox