From: Laurent Pinchart <laurent.pinchart@ideasonboard•com>
To: Krzysztof Kozlowski <krzk@kernel•org>
Cc: Guoniu Zhou <guoniu.zhou@oss•nxp.com>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Shawn Guo <shawnguo@kernel•org>,
Sascha Hauer <s.hauer@pengutronix•de>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Fabio Estevam <festevam@gmail•com>, Frank Li <frank.li@nxp•com>,
imx@lists•linux.dev, linux-media@vger•kernel.org,
devicetree@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, Guoniu Zhou <guoniu.zhou@nxp•com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss•qualcomm.com>
Subject: Re: [PATCH v8 1/2] media: dt-bindings: Add CSI Pixel Formatter DT bindings
Date: Wed, 27 May 2026 13:45:04 +0200 [thread overview]
Message-ID: <20260527114504.GA480025@killaraus.ideasonboard.com> (raw)
In-Reply-To: <14f9923e-ae0a-4e69-b3b9-a7353b84b9f8@kernel.org>
On Wed, May 27, 2026 at 11:37:34AM +0200, Krzysztof Kozlowski wrote:
> On 26/05/2026 11:44, Laurent Pinchart wrote:
> >>> + - |
> >>> + #include <dt-bindings/clock/nxp,imx95-clock.h>
> >>> +
> >>> + syscon@4ac10000 {
> >>> + compatible = "nxp,imx95-camera-csr", "syscon";
> >>
> >> Drop entire node, not relevant. Or actually this example could be in the
> >> parent binding example.
> >
> > I asked for this in the review of a previous version. The example only
> > stated "formatter@20" and it was not mentioned anywhere that the device
> > was supposed to be a child node of a syscon. The driver reads the reg
>
> Binding does not have to state that. Parent's device binding will state
> that.
>
> > property and uses it as an offset to the regmap of the syscon, I wanted
> > to see where/how the node was meant to be integrated in DT.
>
> Sure, parent's device schema should have complete example. But we never
> add the parent compatibles to the child schema - that's leading to
> additional work later with no real benefits (that's only example, so no
> real code except maintenance effort).
OK. There was no mention of the child in the parent's bindings in the
previous version. Now that it's being fixed, we can drop the parent
here.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2026-05-27 11:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 8:12 [PATCH v8 0/2] media: nxp: Add CSI Pixel Formatter support Guoniu Zhou
2026-05-25 8:12 ` [PATCH v8 1/2] media: dt-bindings: Add CSI Pixel Formatter DT bindings Guoniu Zhou
2026-05-25 10:43 ` Rob Herring (Arm)
2026-05-26 9:13 ` Krzysztof Kozlowski
2026-05-26 9:33 ` [EXT] " G.N. Zhou
2026-05-26 9:44 ` Laurent Pinchart
2026-05-27 9:37 ` Krzysztof Kozlowski
2026-05-27 9:39 ` Krzysztof Kozlowski
2026-05-27 11:45 ` Laurent Pinchart [this message]
2026-05-25 8:12 ` [PATCH v8 2/2] media: nxp: Add i.MX95 CSI pixel formatter v4l2 driver Guoniu Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527114504.GA480025@killaraus.ideasonboard.com \
--to=laurent.pinchart@ideasonboard$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=frank.li@nxp$(echo .)com \
--cc=guoniu.zhou@nxp$(echo .)com \
--cc=guoniu.zhou@oss$(echo .)nxp.com \
--cc=imx@lists$(echo .)linux.dev \
--cc=kernel@pengutronix$(echo .)de \
--cc=krzk+dt@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=krzysztof.kozlowski@oss$(echo .)qualcomm.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=mchehab@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox