From: Harsh Jain <h.jain@amd•com>
To: <srini@kernel•org>, <linux-arm-kernel@lists•infradead.org>,
<michal.simek@amd•com>, <sarat.chand.savitala@amd•com>,
<harish.ediga@amd•com>
Cc: Harsh Jain <h.jain@amd•com>
Subject: [PATCH 1/3] nvmem: zynqmp_nvmem: Correct error message for PUF user fuse
Date: Thu, 28 May 2026 12:13:21 +0530 [thread overview]
Message-ID: <20260528064323.596195-2-h.jain@amd.com> (raw)
In-Reply-To: <20260528064323.596195-1-h.jain@amd.com>
From: Harish Ediga <harish.ediga@amd•com>
P_USER_0_64_UPPER_MASK is defined as GENMASK(31, 16), which masks the
upper 16 bits (2 bytes), so the old "lower 4 bytes" wording was
incorrect -- only the lower 2 bytes (bits 15:0) are programmable.
Fixes: 737c0c8d07b5 ("nvmem: zynqmp_nvmem: Add support to access efuse")
Signed-off-by: Harish Ediga <harish.ediga@amd•com>
Co-developed-by: Harsh Jain <h.jain@amd•com>
Signed-off-by: Harsh Jain <h.jain@amd•com>
---
drivers/nvmem/zynqmp_nvmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/zynqmp_nvmem.c b/drivers/nvmem/zynqmp_nvmem.c
index d297ff150dc0..6be00a2be9e4 100644
--- a/drivers/nvmem/zynqmp_nvmem.c
+++ b/drivers/nvmem/zynqmp_nvmem.c
@@ -84,7 +84,7 @@ static int zynqmp_efuse_access(void *context, unsigned int offset,
if ((offset == EFUSE_PUF_START_OFFSET ||
offset == EFUSE_PUF_MID_OFFSET) &&
value & P_USER_0_64_UPPER_MASK) {
- dev_err(dev, "Only lower 4 bytes are allowed to be programmed in P_USER_0 & P_USER_64\n");
+ dev_err(dev, "Only lower 2 bytes are allowed to be programmed in P_USER_0 & P_USER_64\n");
return -EOPNOTSUPP;
}
--
2.34.1
next prev parent reply other threads:[~2026-05-28 6:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 6:43 [PATCH 0/3]nvmem: zynqmp_nvmem: Cleanup and bug fixes Harsh Jain
2026-05-28 6:43 ` Harsh Jain [this message]
2026-05-28 6:43 ` [PATCH 2/3] nvmem: zynqmp_nvmem: Use streaming DMA with single kmalloc block Harsh Jain
2026-05-28 6:43 ` [PATCH 3/3] nvmem: zynqmp_nvmem: Drop add_legacy_fixed_of_cells flag Harsh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528064323.596195-2-h.jain@amd.com \
--to=h.jain@amd$(echo .)com \
--cc=harish.ediga@amd$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=michal.simek@amd$(echo .)com \
--cc=sarat.chand.savitala@amd$(echo .)com \
--cc=srini@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox