From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: Rosen Penev <rosenp@gmail•com>
Cc: linux-serial@vger•kernel.org, Jiri Slaby <jirislaby@kernel•org>,
Frank Li <Frank.Li@nxp•com>,
Sascha Hauer <s.hauer@pengutronix•de>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Fabio Estevam <festevam@gmail•com>,
"open list:TTY LAYER AND SERIAL DRIVERS"
<linux-kernel@vger•kernel.org>,
"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<imx@lists•linux.dev>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCHv2] serial: mxs-auart: fix probe error paths and clock handling
Date: Sun, 31 May 2026 10:12:03 +0200 [thread overview]
Message-ID: <2026053149-baggy-reaction-ff9d@gregkh> (raw)
In-Reply-To: <CAKxU2N8bNT+irM-gOk9SM5DHPbcbh7zvNM7n4wF5+q4TSEMkSA@mail.gmail.com>
On Sun, May 31, 2026 at 01:00:21AM -0700, Rosen Penev wrote:
> On Sun, May 31, 2026 at 12:52 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation•org> wrote:
> >
> > On Sat, May 30, 2026 at 12:55:03PM -0700, Rosen Penev wrote:
> > > Sashiko reported three pre-existing bugs in the mxs-auart driver:
> > >
> > > - For non-ASM9260 variants, mxs_get_clks() obtained the clock but never
> > > prepared/enabled it, leaving register accesses in probe at risk of
> > > faulting if the bootloader had gated the clock.
> > > - The error path and remove function used pdev->id instead of
> > > s->port.line to clear the auart_port[] slot. For DT-probed devices
> > > pdev->id is -1, causing an out-of-bounds write and leaving a dangling
> > > pointer in the array.
> > > - The probe error path called iounmap() while the IRQ was still
> > > registered. An interrupt during that window would dereference the
> > > unmapped membase.
> >
> > This should still be broken up into smaller pieces, don't you think?
> >
> > Whenever you have to list the different things you do in a patch, that's
> > a huge hint to do so.
> I'll do so. Although I doubt the bot will be happy either way.
What bot? Yours? If so, please don't use it.
prev parent reply other threads:[~2026-05-31 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 19:55 [PATCHv2] serial: mxs-auart: fix probe error paths and clock handling Rosen Penev
2026-05-31 7:51 ` Greg Kroah-Hartman
2026-05-31 8:00 ` Rosen Penev
2026-05-31 8:12 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026053149-baggy-reaction-ff9d@gregkh \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=Frank.Li@nxp$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=jirislaby@kernel$(echo .)org \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=rosenp@gmail$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox