Subject: Re: [PATCH v9 4/4] coresight: cti: expose banked sysfs registers for Qualcomm extended CTI

From: Leo Yan <[email-masked]>
Date: Mon, 1 Jun 2026 11:48:21 +0100

On Mon, Jun 01, 2026 at 10:08:55AM +0800, Yingchao Deng (Consultant) wrote:

[...]

>   I noticed that among the new sysfs knobs in this series, the
>   integration test registers (ittrigin[1-3], ittrigout[1-3],
>   ittrigoutack[1-3], ittriginack[1-3]) have no existing documentation
>   for their base (index-0) counterparts, which were added long before
>   this series.

Ah, thanks for pointing out the missed piece!

>   Two options for patch 5/5:
> 
>     (a) Document only the knobs whose base versions are already
>         documented (triginstatus[1-3] and trigoutstatus[1-3]).
> 
>     (b) Document everything in patch 5/5 — both the new indexed
>         variants and the previously missing base IT register entries.

Please use option (b). Could you fold the code piece below into patch 5?

Note, we cannot merge ittrigin and ittrigin[1-3] into a single entry
because they were introduced in different kernel versions.

@Mike, if any chance you could give a review on this?

---8<---

--- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-cti
+++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-cti
@@ -134,6 +134,60 @@ KernelVersion:	5.7
 Contact:	Mike Leach or Mathieu Poirier
 Description:	(Read) read current status of output trigger signals.
 
+What:		/sys/bus/coresight/devices/<cti-name>/regs/itctrl
+Date:		March 2020
+KernelVersion	5.7
+Contact:	[email-masked]
+Description:	(RW) Control integration mode.
+
+What:		/sys/bus/coresight/devices/<cti-name>/regs/itchin
+Date:		March 2020
+KernelVersion	5.7
+Contact:	[email-masked]
+Description:	(Read) Read the values of the CTCHIN inputs.
+
+What:		/sys/bus/coresight/devices/<cti-name>/regs/itchinack
+Date:		March 2020
+KernelVersion	5.7
+Contact:	[email-masked]
+Description:	(Write) Write the value of the CTCHINACK input.
+
+What:		/sys/bus/coresight/devices/<cti-name>/regs/ittrigin
+Date:		March 2020
+KernelVersion	5.7
+Contact:	[email-masked]
+Description:	(Read) Read the values of the CTTRIGIN inputs.
+
+What:		/sys/bus/coresight/devices/<cti-name>/regs/ittriginack
+Date:		March 2020
+KernelVersion	5.7
+Contact:	[email-masked]
+Description:	(Write) Write the value of the CTTRIGINACK input.
+
+What:		/sys/bus/coresight/devices/<cti-name>/regs/itchout
+Date:		March 2020
+KernelVersion	5.7
+Contact:	[email-masked]
+Description:	(RW) Read or write the value of the CTCHOUT outputs.
+
+What:		/sys/bus/coresight/devices/<cti-name>/regs/itchoutack
+Date:		March 2020
+KernelVersion	5.7
+Contact:	[email-masked]
+Description:	(Read) Read the value of the CTCHOUTACK input.
+
+What:		/sys/bus/coresight/devices/<cti-name>/regs/ittrigout
+Date:		March 2020
+KernelVersion	5.7
+Contact:	[email-masked]
+Description:	(RW) Read or write the value of the CTTRIGOUT outputs.
+
+What:		/sys/bus/coresight/devices/<cti-name>/regs/ittrigoutack
+Date:		March 2020
+KernelVersion	5.7
+Contact:	[email-masked]
+Description:	(Read) Read the value of the CTTRIGOUTACK input.
+
 What:		/sys/bus/coresight/devices/<cti-name>/channels/trigin_attach
 Date:		March 2020
 KernelVersion:	5.7