Subject: Re: [PATCH v4 2/3] arm64: dts: freescale: add Aquila iMX95 support

From: Francesco Dolcini <[email-masked]>
Date: Tue, 2 Jun 2026 07:11:54 +0200

On Mon, Jun 01, 2026 at 03:45:50PM -0400, Frank Li wrote:
> On Thu, May 21, 2026 at 07:11:05PM +0200, Franz Schnyder wrote:
> > From: João Paulo Gonçalves <[email-masked]>
> >
> > Add support for the Toradex Aquila iMX95 and its development carrier
> > board.
> >
> > The module consists of an NXP i.MX95 family SoC, up to 16GB LPDDR5 RAM,
> > up to 128GB of storage, a USB 3.2 OTG and USB 2.0 Host, a Gigabit
> > Ethernet PHY, a 10 Gigabit Ethernet interface, an I2C EEPROM and
> > Temperature Sensor, an RX8130 RTC, one Quad lane CSI interface, one Quad
> > lane DSI or CSI interface, one LVDS interface (one or two channels), and
> > some optional addons: DisplayPort (through a DSI-DP bridge), TPM 2.0,
> > and a WiFi/BT module.
> >
> > Link: https://www.toradex.com/computer-on-modules/aquila-arm-family/nxp-imx95
> > Link: https://www.toradex.com/products/carrier-board/aquila-development-board-kit
> > Signed-off-by: João Paulo Gonçalves <[email-masked]>
> > Co-developed-by: Emanuele Ghidoli <[email-masked]>
> > Signed-off-by: Emanuele Ghidoli <[email-masked]>
> > Co-developed-by: Francesco Dolcini <[email-masked]>
> > Signed-off-by: Francesco Dolcini <[email-masked]>
> > Co-developed-by: Antoine Gouby <[email-masked]>
> > Signed-off-by: Antoine Gouby <[email-masked]>
> > Co-developed-by: Ernest Van Hoecke <[email-masked]>
> > Signed-off-by: Ernest Van Hoecke <[email-masked]>
> > Co-developed-by: Franz Schnyder <[email-masked]>
> > Signed-off-by: Franz Schnyder <[email-masked]>
> > ---
> ...
> > +
> > +	carrier_eeprom: eeprom@57 {
> > +		compatible = "st,24c02", "atmel,24c02";
> 
> st,24c02 is not documented.

Do not use checkpatch to check a DT file, you have the DT validator for
that.

st,24c02 is perfectly valid, check Documentation/devicetree/bindings/eeprom/at24.yaml

> > +
> > +	/* Aquila GPIO_08 */
> > +	pinctrl_gpio_8: gpio8grp {
> > +		fsl,pins = <IMX95_PAD_PDM_BIT_STREAM1__AONMIX_TOP_GPIO1_IO_BIT10	0x31e>; /* Aquila C24 */
> > +	};
> 
> Please fix checkpatch worning, it exceed 100 char.

It is wanted to improve read-ability. Can you keep it like that?

Please see Linus option on checkpatch,
https://lore.kernel.org/all/CAHk-=wiwpTUr8keTinnPU8kTN9dpYgDtwM4wONRF_j=[email-masked]/

Francesco