From: Conor Dooley <conor@kernel•org>
To: "Stefan Dösinger" <stefandoesinger@gmail•com>
Cc: Michael Turquette <mturquette@baylibre•com>,
Stephen Boyd <sboyd@kernel•org>, Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Philipp Zabel <p.zabel@pengutronix•de>,
Brian Masney <bmasney@redhat•com>,
linux-clk@vger•kernel.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH RFC v3 1/5] dt-bindings: clk: zte: Add zx297520v3 top clock and reset bindings.
Date: Wed, 3 Jun 2026 00:14:34 +0100 [thread overview]
Message-ID: <20260603-half-almanac-29c5729834cd@spud> (raw)
In-Reply-To: <B8509E97-D235-4373-B29F-B7C79B96FB93@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On Tue, Jun 02, 2026 at 10:09:57PM +0300, Stefan Dösinger wrote:
> Hello Conor,
>
> Thanks for the review!
>
> > Am 29.05.2026 um 19:48 schrieb Conor Dooley <conor@kernel•org>:
> >
> > These are not permitted in bindings, please remove them.
> > Half the time they end up changing because people find other clocks, and
> > they never actually get used in a dts. If you need the definitions, add
> > them to the driver.
>
> I changed the drivers to derive the number of clocks from the clock tables in the driver, as seen e.g. in mediatek clocks.
>
> Before I resend with your suggestions and more Sashiko findings (that thing is good!): Do you have any advice on the questions I raised in my cover letter?
Resend whenever you get around to it, don't need to rush into it. Can
wait for others to give feedback on those questions, none of them seemed
particularly relevant to me, more of something for Stephen or Brian etc.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-06-02 23:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 21:52 [PATCH RFC v3 0/5] ZTE zx297520v3 clock bindings and driver Stefan Dösinger
2026-05-28 21:52 ` [PATCH RFC v3 1/5] dt-bindings: clk: zte: Add zx297520v3 top clock and reset bindings Stefan Dösinger
2026-05-29 16:48 ` Conor Dooley
2026-06-02 19:09 ` Stefan Dösinger
2026-06-02 23:14 ` Conor Dooley [this message]
2026-05-28 21:52 ` [PATCH RFC v3 2/5] dt-bindings: clk: zte: Add zx297520v3 LSP " Stefan Dösinger
2026-05-29 16:49 ` Conor Dooley
2026-05-28 21:53 ` [PATCH RFC v3 3/5] clk: zte: Introduce a driver for zx297520v3 top clocks and resets Stefan Dösinger
2026-06-03 9:14 ` Philipp Zabel
2026-06-03 20:49 ` Stefan Dösinger
2026-06-04 13:44 ` Philipp Zabel
2026-05-28 21:53 ` [PATCH RFC v3 4/5] clk: zte: Introduce a driver for zx297520v3 LSP " Stefan Dösinger
2026-05-28 21:53 ` [PATCH RFC v3 5/5] ARM: dts: zte: Declare a zx297520v3 clock device nodes Stefan Dösinger
2026-06-03 8:50 ` [PATCH RFC v3 0/5] ZTE zx297520v3 clock bindings and driver Philipp Zabel
2026-06-03 20:49 ` Stefan Dösinger
2026-06-04 15:23 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603-half-almanac-29c5729834cd@spud \
--to=conor@kernel$(echo .)org \
--cc=bmasney@redhat$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mturquette@baylibre$(echo .)com \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=robh@kernel$(echo .)org \
--cc=sboyd@kernel$(echo .)org \
--cc=stefandoesinger@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox