From: Sebastian Andrzej Siewior <bigeasy@linutronix•de>
To: Daniel Baluta <daniel.baluta@oss•nxp.com>
Cc: linux-kernel@vger•kernel.org, imx@lists•linux.dev,
linux-arm-kernel@lists•infradead.org,
linux-remoteproc@vger•kernel.org, linux-rt-devel@lists•linux.dev,
Bjorn Andersson <andersson@kernel•org>,
Clark Williams <clrkwllms@kernel•org>,
Fabio Estevam <festevam@gmail•com>, Frank Li <Frank.Li@nxp•com>,
Jassi Brar <jassisinghbrar@gmail•com>,
Mathieu Poirier <mathieu.poirier@linaro•org>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Sascha Hauer <s.hauer@pengutronix•de>,
Steven Rostedt <rostedt@goodmis•org>
Subject: Re: [PATCH v2 6/9] mailbox: imx: Move the RX part of the mailbox into the threaded handler
Date: Wed, 3 Jun 2026 15:20:34 +0200 [thread overview]
Message-ID: <20260603132034.NxZoA4pH@linutronix.de> (raw)
In-Reply-To: <c81d12a8-7544-493f-a947-8f70ad9d409d@oss.nxp.com>
On 2026-06-03 16:18:22 [+0300], Daniel Baluta wrote:
> On 6/3/26 16:05, Sebastian Andrzej Siewior wrote:
> > Move RX callback handling into the threaded handler. This is similar to
> > the TX side except that we explicitly mask the source interrupt in the
> > primary handler and unmask it in the threaded handler again after
> > success. This was done automatically in the TX part.
> >
> > The masking/ unmasking can be removed from imx_mu_specific_rx() since it
> > already happens in the primary/ threaded handler before invoking the
> > channel specific callback.
> >
> > Move RX channel handling into threaded handler.
>
> Hi Sebastian,
>
> It is not very clear from me from the commit message why this change is needed.
> Can you please update the commit message with proper explanation?
The intention is to move the entire interrupt handling into the threaded
handler. The primary handler masks just event, the threaded handler
performs the RX/TX/ event.
I move the individual events step by step so the previous patch moved
the TX, here is RX and the next one does RXDB.
Is this clear now? The cover later explains why this done in the first
place.
Sebastian
next prev parent reply other threads:[~2026-06-03 13:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 13:05 [PATCH v2 0/9] mailbox: imx: Use threaded handler to avoid kworker in imx's remoteproc Sebastian Andrzej Siewior
2026-06-03 13:05 ` [PATCH v2 1/9] mailbox: imx: Add a channel shutdown field Sebastian Andrzej Siewior
2026-06-03 13:05 ` [PATCH v2 2/9] mailbox: imx: Use devm_pm_runtime_enable() Sebastian Andrzej Siewior
2026-06-03 13:05 ` [PATCH v2 3/9] mailbox: imx: use devm_of_platform_populate() Sebastian Andrzej Siewior
2026-06-03 13:05 ` [PATCH v2 4/9] mailbox: imx: Use channel index instead of zero in imx_mu_specific_rx() Sebastian Andrzej Siewior
2026-06-03 13:05 ` [PATCH v2 5/9] mailbox: imx: Start splitting the IRQ handler in primary and threaded handler Sebastian Andrzej Siewior
2026-06-03 13:05 ` [PATCH v2 6/9] mailbox: imx: Move the RX part of the mailbox into the " Sebastian Andrzej Siewior
2026-06-03 13:18 ` Daniel Baluta
2026-06-03 13:20 ` Sebastian Andrzej Siewior [this message]
2026-06-03 13:45 ` Daniel Baluta
2026-06-03 15:26 ` Sebastian Andrzej Siewior
2026-06-03 13:05 ` [PATCH v2 7/9] mailbox: imx: Move the RXDB " Sebastian Andrzej Siewior
2026-06-03 13:05 ` [PATCH v2 8/9] mailbox: imx: Don't force-thread the primary handler Sebastian Andrzej Siewior
2026-06-03 13:05 ` [PATCH v2 9/9] remoteproc: imx_rproc: Invoke the callback directly Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603132034.NxZoA4pH@linutronix.de \
--to=bigeasy@linutronix$(echo .)de \
--cc=Frank.Li@nxp$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=clrkwllms@kernel$(echo .)org \
--cc=daniel.baluta@oss$(echo .)nxp.com \
--cc=festevam@gmail$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=jassisinghbrar@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-remoteproc@vger$(echo .)kernel.org \
--cc=linux-rt-devel@lists$(echo .)linux.dev \
--cc=mathieu.poirier@linaro$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox