From: Sizhe Liu <liusizhe5@huawei•com>
To: <rostedt@goodmis•org>, <mhiramat@kernel•org>,
<mathieu.desnoyers@efficios•com>, <corbet@lwn•net>,
<skhan@linuxfoundation•org>, <bhelgaas@google•com>,
<yangyccccc@gmail•com>, <jic23@kernel•org>,
<john.g.garry@oracle•com>, <will@kernel•org>,
<james.clark@linaro•org>, <mike.leach@arm•com>,
<leo.yan@linux•dev>, <peterz@infradead•org>, <mingo@redhat•com>,
<acme@kernel•org>, <namhyung@kernel•org>, <mark.rutland@arm•com>,
<alexander.shishkin@linux•intel.com>, <jolsa@kernel•org>,
<irogers@google•com>, <adrian.hunter@intel•com>,
<wangyushan12@huawei•com>, <shenyang39@huawei•com>,
<gaozhihao6@h-partners•com>, <yuzhichengcheng@h-partners•com>,
<liyihang9@h-partners•com>
Cc: <linux-kernel@vger•kernel.org>, <linux-pci@vger•kernel.org>,
<linux-perf-users@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>,
<linux-doc@vger•kernel.org>, <linuxarm@huawei•com>,
<prime.zeng@hisilicon•com>, <fanghao11@huawei•com>,
<wuyifan50@huawei•com>, <liusizhe5@huawei•com>
Subject: [PATCH 06/10] perf hisi-ptt: Extract the raw data printing part
Date: Thu, 4 Jun 2026 15:50:01 +0800 [thread overview]
Message-ID: <20260604075005.2219785-7-liusizhe5@huawei.com> (raw)
In-Reply-To: <20260604075005.2219785-1-liusizhe5@huawei.com>
Extract the raw data printing part of the TLP header into
hisi_ptt_print_raw_record() for reuse by subsequent patches that
add field-level parsing of individual DW headers.
Signed-off-by: Sizhe Liu <liusizhe5@huawei•com>
---
.../hisi-ptt-decoder/hisi-ptt-pkt-decoder.c | 29 +++++++++----------
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.c b/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.c
index 33804bcd0642..a5b66e0f7827 100644
--- a/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.c
+++ b/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.c
@@ -93,23 +93,31 @@ union hisi_ptt_field_data {
uint32_t value;
};
-static void hisi_ptt_print_pkt(struct hisi_ptt_pkt_buf *pkt_buf,
- const char *desc)
+static void hisi_ptt_print_raw_record(size_t offset, uint32_t value)
{
const char *color = PERF_COLOR_BLUE;
- uint32_t value;
uint8_t byte;
int i;
- value = le32_to_cpu(*(__le32 *)(pkt_buf->buf + pkt_buf->pos));
printf(".");
- color_fprintf(stdout, color, " %08zx: ", pkt_buf->pos);
+ color_fprintf(stdout, color, " %08zx: ", offset);
for (i = 0; i < HISI_PTT_FIELD_LENGTH; i++) {
byte = (value >> (24 - i * 8)) & 0xFF;
color_fprintf(stdout, color, "%02x ", byte);
}
for (i = 0; i < HISI_PTT_MAX_SPACE_LEN; i++)
color_fprintf(stdout, color, " ");
+}
+
+static void hisi_ptt_print_pkt(struct hisi_ptt_pkt_buf *pkt_buf,
+ const char *desc)
+{
+ const char *color = PERF_COLOR_BLUE;
+ uint32_t value;
+
+ value = le32_to_cpu(*(__le32 *)(pkt_buf->buf + pkt_buf->pos));
+ hisi_ptt_print_raw_record(pkt_buf->pos, value);
+
color_fprintf(stdout, color, " %s\n", desc);
pkt_buf->pos += HISI_PTT_FIELD_LENGTH;
}
@@ -135,18 +143,9 @@ static void hisi_ptt_4dw_print_dw0(struct hisi_ptt_pkt_buf *pkt_buf)
{
const char *color = PERF_COLOR_BLUE;
union hisi_ptt_field_data dw;
- uint8_t byte;
- int i;
dw.value = le32_to_cpu(*(__le32 *)(pkt_buf->buf + pkt_buf->pos));
- printf(".");
- color_fprintf(stdout, color, " %08zx: ", pkt_buf->pos);
- for (i = 0; i < HISI_PTT_FIELD_LENGTH; i++) {
- byte = (dw.value >> (24 - i * 8)) & 0xFF;
- color_fprintf(stdout, color, "%02x ", byte);
- }
- for (i = 0; i < HISI_PTT_MAX_SPACE_LEN; i++)
- color_fprintf(stdout, color, " ");
+ hisi_ptt_print_raw_record(pkt_buf->pos, dw.value);
color_fprintf(stdout, color,
" %s %x %s %x %s %x %s %x %s %x %s %x %s %x %s %x\n",
--
2.33.0
next prev parent reply other threads:[~2026-06-04 7:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 7:49 [PATCH 00/10] perf hisi-ptt: Enhance TLP packet decoder with field-level parsing and versioning Sizhe Liu
2026-06-04 7:49 ` [PATCH 01/10] perf hisi-ptt: Fix spelling and abbreviation errors Sizhe Liu
2026-06-04 7:49 ` [PATCH 02/10] perf hisi-ptt: Fix PTT trace TLP Header parsing Sizhe Liu
2026-06-04 7:49 ` [PATCH 03/10] perf hisi-ptt: Rename hisi_ptt_4dw union for reuse Sizhe Liu
2026-06-04 7:49 ` [PATCH 04/10] perf hisi-ptt: Abstract trace data buf and offset Sizhe Liu
2026-06-04 7:50 ` [PATCH 05/10] perf hisi-ptt: Complete the field names for 4DW and 8DW packets Sizhe Liu
2026-06-04 7:50 ` Sizhe Liu [this message]
2026-06-04 7:50 ` [PATCH 07/10] perf hisi-ptt: Merge 4DW and 8DW HEAD0 printing Sizhe Liu
2026-06-04 7:50 ` [PATCH 08/10] perf hisi-ptt: Add parsing of supported message types Sizhe Liu
2026-06-04 7:50 ` [PATCH 09/10] perf hisi-ptt: Add field-level parsing for header DW2/DW3 Sizhe Liu
2026-06-04 7:50 ` [PATCH 10/10] perf hisi-ptt: Add decoder version compatibility Sizhe Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604075005.2219785-7-liusizhe5@huawei.com \
--to=liusizhe5@huawei$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=adrian.hunter@intel$(echo .)com \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=bhelgaas@google$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=fanghao11@huawei$(echo .)com \
--cc=gaozhihao6@h-partners$(echo .)com \
--cc=irogers@google$(echo .)com \
--cc=james.clark@linaro$(echo .)org \
--cc=jic23@kernel$(echo .)org \
--cc=john.g.garry@oracle$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=leo.yan@linux$(echo .)dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=linuxarm@huawei$(echo .)com \
--cc=liyihang9@h-partners$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mhiramat@kernel$(echo .)org \
--cc=mike.leach@arm$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=prime.zeng@hisilicon$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=shenyang39@huawei$(echo .)com \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=wangyushan12@huawei$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=wuyifan50@huawei$(echo .)com \
--cc=yangyccccc@gmail$(echo .)com \
--cc=yuzhichengcheng@h-partners$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox