From: Adam Young <admiyo@os•amperecomputing.com>
To: Sudeep Holla <sudeep.holla@kernel•org>,
Jassi Brar <jassisinghbrar@gmail•com>
Cc: linux-kernel@vger•kernel.org, linux-hwmon@vger•kernel.org,
"Rafael J . Wysocki" <rafael@kernel•org>,
Len Brown <lenb@kernel•org>,
linux-acpi@vger•kernel.org, Andi Shyti <andi.shyti@kernel•org>,
Guenter Roeck <linux@roeck-us•net>,
Huisong Li <lihuisong@huawei•com>,
MyungJoo Ham <myungjoo.ham@samsung•com>,
Kyungmin Park <kyungmin.park@samsung•com>,
Chanwoo Choi <cw00.choi@samsung•com>,
linux-arm-kernel@lists•infradead.org
Subject: [PATCH v01] mailbox/pcc.c: ignore errors on type 4 channels.
Date: Thu, 4 Jun 2026 12:33:06 -0400 [thread overview]
Message-ID: <20260604163306.160017-1-admiyo@os.amperecomputing.com> (raw)
THE ACPI spec states:
"[The Error status register] Contains the processor relative address,
represented in Generic Address Structure (GAS) format, of the Error status
register. This field is ignored by the OSPM on slave channels"
Which Refers to type 4 channels.
https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/14_Platform_Communications_Channel/Platform_Comm_Channel.html#hw-registers-based-communications-subspace-structure-type-5
Signed-off-by: Adam Young <admiyo@os•amperecomputing.com>
---
drivers/mailbox/pcc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
index 636879ae1db7..0deaf7907ed6 100644
--- a/drivers/mailbox/pcc.c
+++ b/drivers/mailbox/pcc.c
@@ -270,6 +270,9 @@ static int pcc_mbox_error_check_and_clear(struct pcc_chan_info *pchan)
u64 val;
int ret;
+ if (pchan->type == ACPI_PCCT_TYPE_EXT_PCC_SLAVE_SUBSPACE)
+ return 0;
+
ret = pcc_chan_reg_read(&pchan->error, &val);
if (ret)
return ret;
--
2.43.0
reply other threads:[~2026-06-04 16:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604163306.160017-1-admiyo@os.amperecomputing.com \
--to=admiyo@os$(echo .)amperecomputing.com \
--cc=andi.shyti@kernel$(echo .)org \
--cc=cw00.choi@samsung$(echo .)com \
--cc=jassisinghbrar@gmail$(echo .)com \
--cc=kyungmin.park@samsung$(echo .)com \
--cc=lenb@kernel$(echo .)org \
--cc=lihuisong@huawei$(echo .)com \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-hwmon@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=myungjoo.ham@samsung$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=sudeep.holla@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox