public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: heiko@sntech•de (Heiko Stübner)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/2] dmaengine: s3c24xx-dma: Process whole SG chain
Date: Wed, 28 May 2014 22:03:54 +0200	[thread overview]
Message-ID: <2226052.jOkjSV51zk@phil> (raw)
In-Reply-To: <1400617382-7051-1-git-send-email-anarsoul@gmail.com>

Am Dienstag, 20. Mai 2014, 23:23:01 schrieb Vasily Khoruzhick:
> Due to redundant 'break' in loop driver processed only first chunk.
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail•com>

I think I wrote this for v1 already, but here it is again.

Reviewed-by: Heiko Stuebner <heiko@sntech•de>

> ---
> v2: No changes
> v3: No changes
> 
>  drivers/dma/s3c24xx-dma.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c
> index 4eddedb..2167608 100644
> --- a/drivers/dma/s3c24xx-dma.c
> +++ b/drivers/dma/s3c24xx-dma.c
> @@ -961,7 +961,6 @@ static struct dma_async_tx_descriptor
> *s3c24xx_dma_prep_slave_sg( dsg->src_addr = slave_addr;
>  			dsg->dst_addr = sg_dma_address(sg);
>  		}
> -		break;
>  	}
> 
>  	return vchan_tx_prep(&s3cchan->vc, &txd->vd, flags);

  parent reply	other threads:[~2014-05-28 20:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20 20:23 [PATCH v3 1/2] dmaengine: s3c24xx-dma: Process whole SG chain Vasily Khoruzhick
2014-05-20 20:23 ` [PATCH v3 2/2] dmaengine: s3c24xx-dma: Add cyclic transfer support Vasily Khoruzhick
2014-05-28 20:27   ` Heiko Stübner
2014-05-28 20:03 ` Heiko Stübner [this message]
2014-06-01 15:47 ` [PATCH v3 1/2] dmaengine: s3c24xx-dma: Process whole SG chain Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2226052.jOkjSV51zk@phil \
    --to=heiko@sntech$(echo .)de \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox