From: Andrew Jeffery <andrew@codeconstruct•com.au>
To: Ninad Palsule <ninad@linux•ibm.com>,
eajames@linux•ibm.com, robh@kernel•org, krzk+dt@kernel•org,
conor+dt@kernel•org, joel@jms•id.au, devicetree@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-aspeed@lists•ozlabs.org, linux-kernel@vger•kernel.org
Cc: Manojkiran Eda <manojkiran.eda@gmail•com>
Subject: Re: [PATCH v1 2/7] ARM: dts: aspeed: system1: Enable video engine
Date: Mon, 18 May 2026 21:08:38 +0930 [thread overview]
Message-ID: <26a62f67c2aa5fafb019b59893d374047d2f5e70.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20260421224551.1611818-3-ninad@linux.ibm.com>
On Tue, 2026-04-21 at 17:45 -0500, Ninad Palsule wrote:
> From: Manojkiran Eda <manojkiran.eda@gmail•com>
>
> This patch enables the aspeed video engine support in ASPEED BMC for
> IBM System1. It is crucial for facilitating the BMC's video capture
> and redirection capabilities, which are integral to remote management
> and KVM (Keyboard-Video-Mouse) over IP functionality.
This is a real nitpick, but: The commit message seems a bit too
grandiose for my tastes. Can you make it more succinct? Writing in
imperative mood to avoid "this patch" is generally recommended too:
https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
Andrew
>
> Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail•com>
> Signed-off-by: Ninad Palsule <ninad@linux•ibm.com>
> ---
> arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> index 488d0b3916a1..0ca799893791 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> @@ -531,6 +531,10 @@ &lpc_snoop {
> snoop-ports = <0x80>, <0x81>;
> };
>
> +&video {
> + status = "okay";
> +};
> +
> &i2c0 {
> status = "okay";
>
next prev parent reply other threads:[~2026-05-18 11:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 22:45 [PATCH v1 0/7] DTS updates for system1 BMC Ninad Palsule
2026-04-21 22:45 ` [PATCH v1 1/7] ARM: dts: aspeed: system1: Disable vuart2 Ninad Palsule
2026-04-21 22:45 ` [PATCH v1 2/7] ARM: dts: aspeed: system1: Enable video engine Ninad Palsule
2026-05-18 11:38 ` Andrew Jeffery [this message]
2026-04-21 22:45 ` [PATCH v1 3/7] ARM: dts: aspeed: system1: Add usb virtual hub dev Ninad Palsule
2026-04-21 22:45 ` [PATCH v1 4/7] ARM: dts: aspeed: system1: Enable temp sensors Ninad Palsule
2026-04-21 22:45 ` [PATCH v1 5/7] ARM: dts: aspeed: system1: disable NCSI net port Ninad Palsule
2026-04-21 22:45 ` [PATCH v1 6/7] ARM: dts: aspeed: system1: Added status LEDs Ninad Palsule
2026-04-21 22:45 ` [PATCH v1 7/7] ARM: dts: aspeed: system1: DTS updates Ninad Palsule
2026-05-18 11:34 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26a62f67c2aa5fafb019b59893d374047d2f5e70.camel@codeconstruct.com.au \
--to=andrew@codeconstruct$(echo .)com.au \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=eajames@linux$(echo .)ibm.com \
--cc=joel@jms$(echo .)id.au \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-aspeed@lists$(echo .)ozlabs.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=manojkiran.eda@gmail$(echo .)com \
--cc=ninad@linux$(echo .)ibm.com \
--cc=robh@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox