From: Cristian Marussi <cristian.marussi@arm•com>
To: Dave Martin <Dave.Martin@arm•com>
Cc: amit.kachhap@arm•com, andreyknvl@google•com, shuah@kernel•org,
linux-arm-kernel@lists•infradead.org,
linux-kselftest@vger•kernel.org
Subject: Re: [PATCH v5 11/11] kselftest: arm64: fake_sigreturn_misaligned_sp
Date: Mon, 9 Sep 2019 19:32:20 +0100 [thread overview]
Message-ID: <28314ab6-efd6-34b2-ed32-5f0f4fbf5cae@arm.com> (raw)
In-Reply-To: <20190904114944.GB27757@arm.com>
On 04/09/2019 12:49, Dave Martin wrote:
> On Mon, Sep 02, 2019 at 12:29:32pm +0100, Cristian Marussi wrote:
>> Add a simple fake_sigreturn testcase which places a valid sigframe on a
>> non-16 bytes aligned SP. Expects a SIGSEGV on test PASS.
>>
>> Signed-off-by: Cristian Marussi <cristian.marussi@arm•com>
>> ---
>> v3 --> v4
>> - fix commit
>> - use new fake_sigreturn misalig_bytes params
>> - removed TODO
>> - added test description
>> ---
>> .../testcases/fake_sigreturn_misaligned_sp.c | 37 +++++++++++++++++++
>> 1 file changed, 37 insertions(+)
>> create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c
>>
>> diff --git a/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c
>> new file mode 100644
>> index 000000000000..1e089e66f9f3
>> --- /dev/null
>> +++ b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c
>> @@ -0,0 +1,37 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (C) 2019 ARM Limited
>> + *
>> + * Place a fake sigframe on the stack at a misaligned SP: on sigreturn
>> + * Kernel must spot this attempt and the test case is expected to be
>> + * terminated via SEGV.
>> + */
>> +
>> +#include <signal.h>
>> +#include <ucontext.h>
>> +
>> +#include "test_signals_utils.h"
>> +#include "testcases.h"
>> +
>> +struct fake_sigframe sf;
>> +
>> +static int fake_sigreturn_misaligned_run(struct tdescr *td,
>> + siginfo_t *si, ucontext_t *uc)
>> +{
>> + /* just to fill the ucontext_t with something real */
>> + if (!get_current_context(td, &sf.uc))
>> + return 1;
>> +
>> + /* Forcing sigframe on misaligned SP (16 + 3) */
>> + fake_sigreturn(&sf, sizeof(sf), 3);
>
> Can we add tests on the TODO list for other misalignments?
>
> a) 4 (i.e., __alignof__(struct _aarch64_ctx))
> b) 8 (i.e., sizeof(struct _aarch64_ctx))
>
> This may help catch potential wrong-bitmask bugs in the kernel when
> checking the alignment. Similarly to my suggestion on patch 10, these
> can go on the TODO list and added later (probably macro-ised).
>
Ok
> For now, let's get this series settled as-is -- so, after responding to
> nits:
>
> Reviewed-by: Dave Martin <Dave.Martin@arm•com>
>
Thanks
Cristian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-09 18:32 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 11:29 [PATCH v5 00/11] Add arm64/signal initial kselftest support Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 01/11] kselftest: arm64: add skeleton Makefile Cristian Marussi
2019-09-03 9:26 ` Amit Kachhap
2019-09-03 9:45 ` Cristian Marussi
2019-09-05 17:57 ` Cristian Marussi
2019-09-09 12:42 ` Amit Kachhap
2019-09-16 11:41 ` Dave Martin
2019-09-04 11:47 ` Dave Martin
2019-09-05 13:45 ` Cristian Marussi
2019-09-05 14:18 ` Dave Martin
2019-09-02 11:29 ` [PATCH v5 02/11] kselftest: arm64: add common utils and one testcase Cristian Marussi
2019-09-04 11:47 ` Dave Martin
2019-09-06 10:26 ` Cristian Marussi
2019-09-16 11:40 ` Dave Martin
2019-09-02 11:29 ` [PATCH v5 03/11] kselftest: arm64: mangle_pstate_invalid_daif_bits Cristian Marussi
2019-09-04 11:48 ` Dave Martin
2019-09-02 11:29 ` [PATCH v5 04/11] kselftest: arm64: mangle_pstate_invalid_mode_el[123][ht] Cristian Marussi
2019-09-04 11:48 ` Dave Martin
2019-09-02 11:29 ` [PATCH v5 05/11] kselftest: arm64: mangle_pstate_ssbs_regs Cristian Marussi
2019-09-04 11:48 ` Dave Martin
2019-09-09 15:51 ` Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 06/11] kselftest: arm64: fake_sigreturn_bad_magic Cristian Marussi
2019-09-04 11:48 ` Dave Martin
2019-09-09 17:31 ` Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 07/11] kselftest: arm64: fake_sigreturn_bad_size_for_magic0 Cristian Marussi
2019-09-04 11:49 ` Dave Martin
2019-09-09 17:47 ` Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 08/11] kselftest: arm64: fake_sigreturn_missing_fpsimd Cristian Marussi
2019-09-04 11:49 ` Dave Martin
2019-09-09 17:51 ` Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 09/11] kselftest: arm64: fake_sigreturn_duplicated_fpsimd Cristian Marussi
2019-09-04 11:49 ` Dave Martin
2019-09-05 12:15 ` Cristian Marussi
2019-09-05 12:39 ` Dave Martin
2019-09-05 13:32 ` Cristian Marussi
2019-09-05 14:20 ` Dave Martin
2019-09-09 18:03 ` Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 10/11] kselftest: arm64: fake_sigreturn_bad_size Cristian Marussi
2019-09-04 11:49 ` Dave Martin
2019-09-09 18:11 ` Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 11/11] kselftest: arm64: fake_sigreturn_misaligned_sp Cristian Marussi
2019-09-04 11:49 ` Dave Martin
2019-09-09 18:32 ` Cristian Marussi [this message]
2019-09-04 11:47 ` [PATCH v5 00/11] Add arm64/signal initial kselftest support Dave Martin
2019-09-10 12:25 ` Cristian Marussi
2019-09-16 12:14 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28314ab6-efd6-34b2-ed32-5f0f4fbf5cae@arm.com \
--to=cristian.marussi@arm$(echo .)com \
--cc=Dave.Martin@arm$(echo .)com \
--cc=amit.kachhap@arm$(echo .)com \
--cc=andreyknvl@google$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox