From: Heiko Stuebner <heiko@sntech•de>
To: Douglas Anderson <dianders@chromium•org>
Cc: Mark Rutland <mark.rutland@arm•com>,
devicetree@vger•kernel.org,
Viresh Kumar <viresh.kumar@linaro•org>,
linux-kernel@vger•kernel.org, linux-rockchip@lists•infradead.org,
Rob Herring <robh+dt@kernel•org>,
Sean Paul <seanpaul@chromium•org>,
Enric Balletbo i Serra <enric.balletbo@collabora•com>,
Robin Murphy <robin.murphy@arm•com>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Fix override mode for rk3399-kevin panel
Date: Thu, 10 Oct 2019 23:42:21 +0200 [thread overview]
Message-ID: <29647267.xx61tplHq2@phil> (raw)
In-Reply-To: <20191008124949.1.I674acd441997dd0690c86c9003743aacda1cf5dd@changeid>
Am Dienstag, 8. Oktober 2019, 21:49:54 CEST schrieb Douglas Anderson:
> When I re-posted Sean's original commit to add the override mode for
> the kevin panel, for some reason I didn't notice that the pixel clock
> wasn't quite right. Looking at /sys/kernel/debug/clk/clk_summary on
> downstream kernels it can be seen that the VOP clock is supposed to be
> 266,666,667 Hz achieved by dividing the 800 MHz PLL by 3.
>
> Looking at history, it seems that even Sean's first patch [1] had this
> funny clock rate. I'm not sure where it came from since the commit
> message specifically mentioned 26666 kHz and the Chrome OS tree [2]
> can be seen to request 266667 kHz.
>
> In any case, let's fix it up. This together with my patch [3] to do
> the proper rounding when setting the clock rate makes the VOP clock
> more proper as seen in /sys/kernel/debug/clk/clk_summary.
>
> [1] https://lore.kernel.org/r/20180206165626.37692-4-seanpaul@chromium.org
> [2] https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-4.4/drivers/gpu/drm/panel/panel-simple.c#1172
> [3] https://lkml.kernel.org/r/20191003114726.v2.1.Ib233b3e706cf6317858384264d5b0ed35657456e@changeid
>
> Fixes: 84ebd2da6d04 ("arm64: dts: rockchip: Specify override mode for kevin panel")
> Cc: Sean Paul <seanpaul@chromium•org>
> Signed-off-by: Douglas Anderson <dianders@chromium•org>
applied as fix for 5.4
Thanks
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-10 21:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 19:49 [PATCH] arm64: dts: rockchip: Fix override mode for rk3399-kevin panel Douglas Anderson
2019-10-10 21:42 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29647267.xx61tplHq2@phil \
--to=heiko@sntech$(echo .)de \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dianders@chromium$(echo .)org \
--cc=enric.balletbo@collabora$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=seanpaul@chromium$(echo .)org \
--cc=viresh.kumar@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox