From: "Yingchao Deng (Consultant)" <quic_yingdeng@quicinc•com>
To: Leo Yan <leo.yan@arm•com>
Cc: Yingchao Deng <yingchao.deng@oss•qualcomm.com>,
Suzuki K Poulose <suzuki.poulose@arm•com>,
Mike Leach <mike.leach@arm•com>,
James Clark <james.clark@linaro•org>,
Alexander Shishkin <alexander.shishkin@linux•intel.com>,
<coresight@lists•linaro.org>,
<linux-arm-kernel@lists•infradead.org>,
<linux-kernel@vger•kernel.org>, <linux-arm-msm@vger•kernel.org>,
<jinlong.mao@oss•qualcomm.com>, <tingwei.zhang@oss•qualcomm.com>,
<jie.gan@oss•qualcomm.com>,
Yingchao Deng <quic_yingdeng@quicinc•com>
Subject: Re: [PATCH v9 4/4] coresight: cti: expose banked sysfs registers for Qualcomm extended CTI
Date: Tue, 2 Jun 2026 17:53:49 +0800 [thread overview]
Message-ID: <30ed489e-13a3-41fa-980b-5a6bcf451760@quicinc.com> (raw)
In-Reply-To: <20260601104821.GM101133@e132581.arm.com>
On 6/1/2026 6:48 PM, Leo Yan wrote:
> On Mon, Jun 01, 2026 at 10:08:55AM +0800, Yingchao Deng (Consultant) wrote:
>
> [...]
>
>> I noticed that among the new sysfs knobs in this series, the
>> integration test registers (ittrigin[1-3], ittrigout[1-3],
>> ittrigoutack[1-3], ittriginack[1-3]) have no existing documentation
>> for their base (index-0) counterparts, which were added long before
>> this series.
> Ah, thanks for pointing out the missed piece!
>
>> Two options for patch 5/5:
>>
>> (a) Document only the knobs whose base versions are already
>> documented (triginstatus[1-3] and trigoutstatus[1-3]).
>>
>> (b) Document everything in patch 5/5 — both the new indexed
>> variants and the previously missing base IT register entries.
> Please use option (b). Could you fold the code piece below into patch 5?
>
> Note, we cannot merge ittrigin and ittrigin[1-3] into a single entry
> because they were introduced in different kernel versions.
Will update accordingly.
Thanks,
Yingchao
> @Mike, if any chance you could give a review on this?
>
> ---8<---
>
> --- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-cti
> +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-cti
> @@ -134,6 +134,60 @@ KernelVersion: 5.7
> Contact: Mike Leach or Mathieu Poirier
> Description: (Read) read current status of output trigger signals.
>
> +What: /sys/bus/coresight/devices/<cti-name>/regs/itctrl
> +Date: March 2020
> +KernelVersion 5.7
> +Contact: coresight@lists•linaro.org
> +Description: (RW) Control integration mode.
> +
> +What: /sys/bus/coresight/devices/<cti-name>/regs/itchin
> +Date: March 2020
> +KernelVersion 5.7
> +Contact: coresight@lists•linaro.org
> +Description: (Read) Read the values of the CTCHIN inputs.
> +
> +What: /sys/bus/coresight/devices/<cti-name>/regs/itchinack
> +Date: March 2020
> +KernelVersion 5.7
> +Contact: coresight@lists•linaro.org
> +Description: (Write) Write the value of the CTCHINACK input.
> +
> +What: /sys/bus/coresight/devices/<cti-name>/regs/ittrigin
> +Date: March 2020
> +KernelVersion 5.7
> +Contact: coresight@lists•linaro.org
> +Description: (Read) Read the values of the CTTRIGIN inputs.
> +
> +What: /sys/bus/coresight/devices/<cti-name>/regs/ittriginack
> +Date: March 2020
> +KernelVersion 5.7
> +Contact: coresight@lists•linaro.org
> +Description: (Write) Write the value of the CTTRIGINACK input.
> +
> +What: /sys/bus/coresight/devices/<cti-name>/regs/itchout
> +Date: March 2020
> +KernelVersion 5.7
> +Contact: coresight@lists•linaro.org
> +Description: (RW) Read or write the value of the CTCHOUT outputs.
> +
> +What: /sys/bus/coresight/devices/<cti-name>/regs/itchoutack
> +Date: March 2020
> +KernelVersion 5.7
> +Contact: coresight@lists•linaro.org
> +Description: (Read) Read the value of the CTCHOUTACK input.
> +
> +What: /sys/bus/coresight/devices/<cti-name>/regs/ittrigout
> +Date: March 2020
> +KernelVersion 5.7
> +Contact: coresight@lists•linaro.org
> +Description: (RW) Read or write the value of the CTTRIGOUT outputs.
> +
> +What: /sys/bus/coresight/devices/<cti-name>/regs/ittrigoutack
> +Date: March 2020
> +KernelVersion 5.7
> +Contact: coresight@lists•linaro.org
> +Description: (Read) Read the value of the CTTRIGOUTACK input.
> +
> What: /sys/bus/coresight/devices/<cti-name>/channels/trigin_attach
> Date: March 2020
> KernelVersion: 5.7
prev parent reply other threads:[~2026-06-02 9:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 12:16 [PATCH v9 0/4] Add Qualcomm extended CTI support Yingchao Deng
2026-05-21 12:16 ` [PATCH v9 1/4] coresight: cti: Convert trigger usage fields to dynamic Yingchao Deng
2026-05-28 18:01 ` Leo Yan
2026-05-29 1:31 ` Yingchao Deng (Consultant)
2026-05-21 12:16 ` [PATCH v9 2/4] coresight: cti: use __reg_addr() helper for register access Yingchao Deng
2026-05-29 14:40 ` Leo Yan
2026-06-01 1:53 ` Yingchao Deng (Consultant)
2026-05-21 12:16 ` [PATCH v9 3/4] coresight: cti: add Qualcomm extended CTI identification and quirks Yingchao Deng
2026-05-22 2:38 ` Jie Gan
2026-05-28 17:11 ` Leo Yan
2026-05-29 1:42 ` Yingchao Deng (Consultant)
2026-05-21 12:16 ` [PATCH v9 4/4] coresight: cti: expose banked sysfs registers for Qualcomm extended CTI Yingchao Deng
2026-05-29 15:32 ` Leo Yan
2026-06-01 2:08 ` Yingchao Deng (Consultant)
2026-06-01 10:48 ` Leo Yan
2026-06-02 9:53 ` Yingchao Deng (Consultant) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30ed489e-13a3-41fa-980b-5a6bcf451760@quicinc.com \
--to=quic_yingdeng@quicinc$(echo .)com \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=coresight@lists$(echo .)linaro.org \
--cc=james.clark@linaro$(echo .)org \
--cc=jie.gan@oss$(echo .)qualcomm.com \
--cc=jinlong.mao@oss$(echo .)qualcomm.com \
--cc=leo.yan@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mike.leach@arm$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=tingwei.zhang@oss$(echo .)qualcomm.com \
--cc=yingchao.deng@oss$(echo .)qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox