From: <Balakrishnan.S@microchip•com>
To: <linux-watchdog@vger•kernel.org>
Cc: <wim@linux-watchdog•org>, <linux@roeck-us•net>,
<alexandre.belloni@bootlin•com>, <andrei.simion@microchip•com>,
<linux-kernel@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH v2 0/2] watchdog: sama5d4_wdt: Fix WDDIS handling for SAM9X60 and SAMA7G5
Date: Wed, 27 May 2026 13:04:52 +0000 [thread overview]
Message-ID: <322c623a-0da8-4821-b0d9-ba2c96bf62ca@microchip.com> (raw)
In-Reply-To: <20260302113310.133989-1-balakrishnan.s@microchip.com>
Hi Wim,
Gentle ping — both patches have been reviewed. Could this be queued for
the next cycle?
Thanks,
Balakrishnan
On 02/03/26 5:03 pm, Balakrishnan Sambath wrote:
> The sama5d4_wdt driver hardcodes AT91_WDT_WDDIS (bit 15) for WDDIS
> detection, which is incorrect for SAM9X60 and SAMA7G5 that use bit 12
> (AT91_SAM9X60_WDDIS). This series fixes the detection by introducing
> a per-device wddis_mask and documents the bit position difference in
> the header.
>
> Changes in v2:
> - Reorder patches: fix first, documentation second
> - Drop patch 3/3, not needed with wddis_mask approach
> - Keep AT91_SAM9X60_* register names, drop _LEGACY/_MODERN naming
> - Limit header changes to WDDIS comments and datasheet references
>
> Balakrishnan Sambath (2):
> watchdog: sama5d4_wdt: Fix WDDIS detection on SAM9X60 and SAMA7G5
> watchdog: at91sam9_wdt.h: Document WDDIS bit position per SoC family
>
> drivers/watchdog/at91sam9_wdt.h | 6 +++--
> drivers/watchdog/sama5d4_wdt.c | 48 +++++++++++++++------------------
> 2 files changed, 25 insertions(+), 29 deletions(-)
>
prev parent reply other threads:[~2026-05-27 13:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 11:33 [PATCH v2 0/2] watchdog: sama5d4_wdt: Fix WDDIS handling for SAM9X60 and SAMA7G5 Balakrishnan Sambath
2026-03-02 11:33 ` [PATCH 1/2] watchdog: sama5d4_wdt: Fix WDDIS detection on " Balakrishnan Sambath
2026-03-02 14:32 ` Alexandre Belloni
2026-03-02 11:33 ` [PATCH 2/2] watchdog: at91sam9_wdt.h: Document WDDIS bit position per SoC family Balakrishnan Sambath
2026-03-02 14:32 ` Alexandre Belloni
2026-05-03 21:03 ` Guenter Roeck
2026-05-27 13:04 ` Balakrishnan.S [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=322c623a-0da8-4821-b0d9-ba2c96bf62ca@microchip.com \
--to=balakrishnan.s@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrei.simion@microchip$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=wim@linux-watchdog$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox