From: okaya@codeaurora•org (Sinan Kaya)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts
Date: Sun, 23 Oct 2016 19:55:29 -0700 [thread overview]
Message-ID: <36163853-ac4a-e146-0c1b-eaf42e8b234d@codeaurora.org> (raw)
In-Reply-To: <CAHp75Vd+u5va3kyqcapeF9JATUfv5gBnoEM_W+frDmMXs5f2Uw@mail.gmail.com>
On 10/21/2016 12:11 PM, Andy Shevchenko wrote:
>> +static void hidma_free_msis(struct hidma_dev *dmadev)
>> > +{
>> > +#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
> Perhaps one #ifdef and two definitions of functions?
I don't think it will make a difference. I'll have to move
#ifdef around the caller of hidma_free_msis instead which
I think is uglier.
The hidma_write_msi_msg function gets called only when
CONFIG_GENERIC_MSI_IRQ_DOMAIN is defined. If I don't put
this around the function definition, I get unused function
warning from the compiler. This is the reason why preprocessor
definition is outside of the function definition.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-10-24 2:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 16:37 [PATCH V7 0/4] dmaengine: qcom_hidma: add MSI interrupt support Sinan Kaya
2016-10-21 16:37 ` [PATCH V7 1/4] dmaengine: qcom_hidma: make pending_tre_count atomic Sinan Kaya
2016-10-21 16:37 ` [PATCH V7 2/4] dmaengine: qcom_hidma: bring out interrupt cause Sinan Kaya
2016-10-21 16:37 ` [PATCH V7 3/4] dmaengine: qcom_hidma: protect common data structures Sinan Kaya
2016-10-21 16:37 ` [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts Sinan Kaya
2016-10-21 19:11 ` Andy Shevchenko
2016-10-24 2:55 ` Sinan Kaya [this message]
2016-10-24 7:30 ` Andy Shevchenko
2016-10-24 11:07 ` okaya at codeaurora.org
2016-11-03 13:17 ` [PATCH V7 0/4] dmaengine: qcom_hidma: add MSI interrupt support Koul, Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36163853-ac4a-e146-0c1b-eaf42e8b234d@codeaurora.org \
--to=okaya@codeaurora$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox