From: Nicolas Frattaroli <nicolas.frattaroli@collabora•com>
To: "Jani Nikula" <jani.nikula@linux•intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux•intel.com>,
"Maxime Ripard" <mripard@kernel•org>,
"Thomas Zimmermann" <tzimmermann@suse•de>,
"David Airlie" <airlied@gmail•com>,
"Simona Vetter" <simona@ffwll•ch>,
"Harry Wentland" <harry.wentland@amd•com>,
"Leo Li" <sunpeng.li@amd•com>,
"Rodrigo Siqueira" <siqueira@igalia•com>,
"Alex Deucher" <alexander.deucher@amd•com>,
"Christian König" <christian.koenig@amd•com>,
"Andrzej Hajda" <andrzej.hajda@intel•com>,
"Neil Armstrong" <neil.armstrong@linaro•org>,
"Robert Foss" <rfoss@kernel•org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard•com>,
"Jonas Karlman" <jonas@kwiboo•se>,
"Jernej Skrabec" <jernej.skrabec@gmail•com>,
"Andy Yan" <andy.yan@rock-chips•com>,
"Liviu Dudau" <liviu.dudau@arm•com>,
"Chun-Kuang Hu" <chunkuang.hu@kernel•org>,
"Philipp Zabel" <p.zabel@pengutronix•de>,
"Matthias Brugger" <matthias.bgg@gmail•com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora•com>,
"Sandy Huang" <hjc@rock-chips•com>,
"Heiko Stübner" <heiko@sntech•de>,
"Liu Ying" <victor.liu@nxp•com>, "Chen-Yu Tsai" <wens@kernel•org>,
"Samuel Holland" <samuel@sholland•org>,
"Dave Stevenson" <dave.stevenson@raspberrypi•com>,
"Maíra Canal" <mcanal@igalia•com>,
"Raspberry Pi Kernel Maintenance" <kernel-list@raspberrypi•com>,
"Maxime Ripard" <mripard@kernel•org>
Cc: dri-devel@lists•freedesktop.org, linux-kernel@vger•kernel.org,
amd-gfx@lists•freedesktop.org,
linux-mediatek@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
linux-rockchip@lists•infradead.org, linux-sunxi@lists•linux.dev,
Jani Nikula <jani.nikula@intel•com>
Subject: Re: [PATCH v3 14/14] drm/display: hdmi: Use drm_output_color_format instead of hdmi_colorspace
Date: Tue, 24 Mar 2026 10:08:44 +0100 [thread overview]
Message-ID: <3687080.mvXUDI8C0e@workhorse> (raw)
In-Reply-To: <20260305-drm-rework-color-formats-v3-14-f3935f6db579@kernel.org>
On Thursday, 5 March 2026 10:05:06 Central European Standard Time Maxime Ripard wrote:
> The hdmi_colorspace enum was defined to represent the colorspace value
> of the HDMI infoframes. It was later used by some HDMI drivers to
> express the output format they should be setting up.
>
> During the introduction of the HDMI helpers, it then was used to
> represent it in the drm_connector_hdmi_state structure.
>
> However, it's always been somewhat redundant with the DRM_COLOR_FORMAT_*
> defines, and now with the drm_output_color_format enum. Let's
> consolidate around drm_output_color_format in drm_connector_hdmi_state
> to facilitate the current effort to provide a global output format
> selection mechanism.
>
> Acked-by: Jani Nikula <jani.nikula@intel•com>
> Signed-off-by: Maxime Ripard <mripard@kernel•org>
> ---
> drivers/gpu/drm/bridge/inno-hdmi.c | 6 +-
> drivers/gpu/drm/bridge/ite-it6263.c | 2 +-
> drivers/gpu/drm/display/drm_bridge_connector.c | 4 +-
> drivers/gpu/drm/display/drm_hdmi_helper.c | 7 +-
> drivers/gpu/drm/display/drm_hdmi_state_helper.c | 52 ++++--
> drivers/gpu/drm/drm_bridge.c | 2 +-
> drivers/gpu/drm/drm_connector.c | 16 +-
> drivers/gpu/drm/mediatek/mtk_hdmi_v2.c | 8 +-
> drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 2 +-
> drivers/gpu/drm/tests/drm_connector_test.c | 80 ++++-----
> drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 182 ++++++++++-----------
> drivers/gpu/drm/vc4/vc4_hdmi.c | 18 +-
> drivers/gpu/drm/vc4/vc4_hdmi.h | 2 +-
> include/drm/bridge/dw_hdmi_qp.h | 2 +-
> include/drm/display/drm_hdmi_helper.h | 3 +-
> include/drm/drm_bridge.h | 5 +-
> include/drm/drm_connector.h | 9 +-
> 17 files changed, 213 insertions(+), 187 deletions(-)
>
Since I've been relying this for a while now and could find no further
issues with the conversion, I'll give this a:
Reviewed-by: Nicolas Frattaroli <nicolas.frattaroli@collabora•com>
Thank you for the refactor!
next prev parent reply other threads:[~2026-03-24 9:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 9:04 [PATCH v3 00/14] drm: Create drm_output_color_format enum Maxime Ripard
2026-03-05 9:04 ` [PATCH v3 01/14] drm/connector: Introduce " Maxime Ripard
2026-03-23 4:07 ` Dmitry Baryshkov
2026-03-05 9:04 ` [PATCH v3 02/14] drm/edid: Convert to " Maxime Ripard
2026-03-23 4:07 ` Dmitry Baryshkov
2026-03-05 9:04 ` [PATCH v3 03/14] drm/display: hdmi: Convert to drm_output_color_format Maxime Ripard
2026-03-23 4:07 ` Dmitry Baryshkov
2026-03-05 9:04 ` [PATCH v3 04/14] drm/amdgpu: display: " Maxime Ripard
2026-03-24 9:11 ` Nicolas Frattaroli
2026-03-05 9:04 ` [PATCH v3 05/14] drm/bridge: adv7511: " Maxime Ripard
2026-03-23 4:07 ` Dmitry Baryshkov
2026-03-05 9:04 ` [PATCH v3 06/14] drm/bridge: analogix: " Maxime Ripard
2026-03-23 4:08 ` Dmitry Baryshkov
2026-03-05 9:04 ` [PATCH v3 07/14] drm/bridge: cadence: " Maxime Ripard
2026-03-23 4:03 ` Dmitry Baryshkov
2026-03-05 9:05 ` [PATCH v3 08/14] drm/bridge: synopsys: dw-dp: " Maxime Ripard
2026-03-23 4:08 ` Dmitry Baryshkov
2026-03-05 9:05 ` [PATCH v3 09/14] drm/bridge: synopsys: dw-hdmi: " Maxime Ripard
2026-03-23 4:08 ` Dmitry Baryshkov
2026-03-05 9:05 ` [PATCH v3 10/14] drm/arm: komeda: " Maxime Ripard
2026-03-05 9:05 ` [PATCH v3 11/14] drm/mediatek: dp: " Maxime Ripard
2026-03-22 14:01 ` Chun-Kuang Hu
2026-03-05 9:05 ` [PATCH v3 12/14] drm/rockchip: analogix: " Maxime Ripard
2026-03-24 9:16 ` Nicolas Frattaroli
2026-03-05 9:05 ` [PATCH v3 13/14] drm/connector: Remove DRM_COLOR_FORMAT defines Maxime Ripard
2026-03-23 4:08 ` Dmitry Baryshkov
2026-03-05 9:05 ` [PATCH v3 14/14] drm/display: hdmi: Use drm_output_color_format instead of hdmi_colorspace Maxime Ripard
2026-03-23 4:10 ` Dmitry Baryshkov
2026-03-24 9:08 ` Nicolas Frattaroli [this message]
2026-03-24 12:55 ` [PATCH v3 00/14] drm: Create drm_output_color_format enum Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3687080.mvXUDI8C0e@workhorse \
--to=nicolas.frattaroli@collabora$(echo .)com \
--cc=Laurent.pinchart@ideasonboard$(echo .)com \
--cc=airlied@gmail$(echo .)com \
--cc=alexander.deucher@amd$(echo .)com \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=andrzej.hajda@intel$(echo .)com \
--cc=andy.yan@rock-chips$(echo .)com \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=christian.koenig@amd$(echo .)com \
--cc=chunkuang.hu@kernel$(echo .)org \
--cc=dave.stevenson@raspberrypi$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=harry.wentland@amd$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=hjc@rock-chips$(echo .)com \
--cc=jani.nikula@intel$(echo .)com \
--cc=jani.nikula@linux$(echo .)intel.com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jonas@kwiboo$(echo .)se \
--cc=kernel-list@raspberrypi$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=liviu.dudau@arm$(echo .)com \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mcanal@igalia$(echo .)com \
--cc=mripard@kernel$(echo .)org \
--cc=neil.armstrong@linaro$(echo .)org \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=rfoss@kernel$(echo .)org \
--cc=samuel@sholland$(echo .)org \
--cc=simona@ffwll$(echo .)ch \
--cc=siqueira@igalia$(echo .)com \
--cc=sunpeng.li@amd$(echo .)com \
--cc=tzimmermann@suse$(echo .)de \
--cc=victor.liu@nxp$(echo .)com \
--cc=wens@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox