From: David Hildenbrand <david@redhat•com>
To: Walter Wu <walter-zh.wu@mediatek•com>,
Andrey Ryabinin <aryabinin@virtuozzo•com>,
Alexander Potapenko <glider@google•com>,
Dmitry Vyukov <dvyukov@google•com>,
Matthias Brugger <matthias.bgg@gmail•com>,
Andrew Morton <akpm@linux-foundation•org>,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
Will Deacon <will@kernel•org>,
Andrey Konovalov <andreyknvl@google•com>,
Arnd Bergmann <arnd@arndb•de>,
Thomas Gleixner <tglx@linutronix•de>,
Michal Hocko <mhocko@kernel•org>, Qian Cai <cai@lca•pw>
Cc: wsd_upstream@mediatek•com, linux-kernel@vger•kernel.org,
kasan-dev@googlegroups•com, linux-mm@kvack•org,
linux-mediatek@lists•infradead.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v2 1/2] mm/page_ext: support to record the last stack of page
Date: Mon, 9 Sep 2019 12:57:03 +0200 [thread overview]
Message-ID: <36b5a8e0-2783-4c0e-4fc7-78ea652ba475@redhat.com> (raw)
In-Reply-To: <20190909085339.25350-1-walter-zh.wu@mediatek.com>
On 09.09.19 10:53, Walter Wu wrote:
> KASAN will record last stack of page in order to help programmer
> to see memory corruption caused by page.
>
> What is difference between page_owner and our patch?
> page_owner records alloc stack of page, but our patch is to record
> last stack(it may be alloc or free stack of page).
>
> Signed-off-by: Walter Wu <walter-zh.wu@mediatek•com>
> ---
> mm/page_ext.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/mm/page_ext.c b/mm/page_ext.c
> index 5f5769c7db3b..7ca33dcd9ffa 100644
> --- a/mm/page_ext.c
> +++ b/mm/page_ext.c
> @@ -65,6 +65,9 @@ static struct page_ext_operations *page_ext_ops[] = {
> #if defined(CONFIG_IDLE_PAGE_TRACKING) && !defined(CONFIG_64BIT)
> &page_idle_ops,
> #endif
> +#ifdef CONFIG_KASAN
> + &page_stack_ops,
> +#endif
> };
>
> static unsigned long total_usage;
>
Are you sure this patch compiles?
t460s: ~/git/linux virtio-mem $ git grep page_stack_ops
t460s: ~/git/linux virtio-mem $
--
Thanks,
David / dhildenb
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-09 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 8:53 [PATCH v2 1/2] mm/page_ext: support to record the last stack of page Walter Wu
2019-09-09 10:57 ` David Hildenbrand [this message]
2019-09-10 1:07 ` Walter Wu
2019-09-10 9:31 ` Kirill A. Shutemov
2019-09-10 9:43 ` Walter Wu
2019-09-09 12:59 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36b5a8e0-2783-4c0e-4fc7-78ea652ba475@redhat.com \
--to=david@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andreyknvl@google$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=aryabinin@virtuozzo$(echo .)com \
--cc=cai@lca$(echo .)pw \
--cc=dvyukov@google$(echo .)com \
--cc=glider@google$(echo .)com \
--cc=kasan-dev@googlegroups$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mhocko@kernel$(echo .)org \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=tglx@linutronix$(echo .)de \
--cc=walter-zh.wu@mediatek$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=wsd_upstream@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox