From: 李志 <lizhi2@eswincomputing•com>
To: "Jakub Kicinski" <kuba@kernel•org>
Cc: andrew+netdev@lunn•ch, devicetree@vger•kernel.org,
davem@davemloft•net, edumazet@google•com, robh@kernel•org,
krzk+dt@kernel•org, conor+dt@kernel•org, netdev@vger•kernel.org,
pabeni@redhat•com, mcoquelin.stm32@gmail•com,
alexandre.torgue@foss•st.com, rmk+kernel@armlinux•org.uk,
pjw@kernel•org, palmer@dabbelt•com, aou@eecs•berkeley.edu,
alex@ghiti•fr, linux-riscv@lists•infradead.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, maxime.chevallier@bootlin•com,
ningyu@eswincomputing•com, linmin@eswincomputing•com,
pinkesh.vaghela@einfochips•com, pritesh.patel@einfochips•com,
weishangjuan@eswincomputing•com, horms@kernel•org
Subject: Re: Re: [PATCH net-next v7 2/4] net: stmmac: eic7700: enable clocks before syscon access and correct RX sampling timing
Date: Wed, 6 May 2026 10:10:57 +0800 (GMT+08:00) [thread overview]
Message-ID: <38d052b7.7a70.19dfb0d782b.Coremail.lizhi2@eswincomputing.com> (raw)
In-Reply-To: <20260430163551.7491407a@kernel.org>
> -----原始邮件-----
> 发件人: "Jakub Kicinski" <kuba@kernel•org>
> 发送时间:2026-05-01 07:35:51 (星期五)
> 收件人: 李志 <lizhi2@eswincomputing•com>
> 抄送: andrew+netdev@lunn•ch, devicetree@vger•kernel.org, davem@davemloft•net, edumazet@google•com, robh@kernel•org, krzk+dt@kernel•org, conor+dt@kernel•org, netdev@vger•kernel.org, pabeni@redhat•com, mcoquelin.stm32@gmail•com, alexandre.torgue@foss•st.com, rmk+kernel@armlinux•org.uk, pjw@kernel•org, palmer@dabbelt•com, aou@eecs•berkeley.edu, alex@ghiti•fr, linux-riscv@lists•infradead.org, linux-stm32@st-md-mailman•stormreply.com, linux-arm-kernel@lists•infradead.org, linux-kernel@vger•kernel.org, maxime.chevallier@bootlin•com, ningyu@eswincomputing•com, linmin@eswincomputing•com, pinkesh.vaghela@einfochips•com, pritesh.patel@einfochips•com, weishangjuan@eswincomputing•com, horms@kernel•org
> 主题: Re: [PATCH net-next v7 2/4] net: stmmac: eic7700: enable clocks before syscon access and correct RX sampling timing
>
> On Thu, 30 Apr 2026 14:43:50 +0800 (GMT+08:00) 李志 wrote:
> > > Why Fixes? If eth1 never worked this is not a fix but new functionality
> > > If you want to make this a fix to prevent incompatibility - cut it down
> > > just to the eth0 changes.
> > >
> > Thank you for the suggestion.
> >
> > You're right that eth1 never worked at Gigabit speed, so this should
> > not be treated as a fix.
> >
> > In v8, I will split the changes into two patches within the same series:
> > - Patch 1 will contain only the fixes affecting the existing eth0
> > functionality, and will keep the Fixes tag.
> > - Patch 2 will add the eth1 support (RX clock inversion workaround)
> > as new functionality, without a Fixes tag.
> >
> > Please let me know if you would prefer a different split or ordering.
>
> If you want to consider some part of this commit a fix it has to be
> posted separately to the net tree (rather than net-next).
> Once it's merged and makes it way over to the net-next tree (each
> Thursday) you can post the net-next chnages for eth1
Thanks, understood.
I will split the changes accordingly:
- Send the eth0 fixes as a new v1 series targeting net.
- Send the eth1 enablement as a new v1 series targeting net-next.
Thanks for the guidance.
next prev parent reply other threads:[~2026-05-06 2:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 7:23 [PATCH net-next v7 0/4] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing lizhi2
2026-04-27 7:24 ` [PATCH net-next v7 1/4] dt-bindings: ethernet: eswin: add clock sampling control lizhi2
2026-04-29 1:28 ` Andrew Lunn
2026-04-27 7:25 ` [PATCH net-next v7 2/4] net: stmmac: eic7700: enable clocks before syscon access and correct RX sampling timing lizhi2
2026-04-29 1:06 ` Jakub Kicinski
2026-04-30 6:43 ` 李志
2026-04-30 23:35 ` Jakub Kicinski
2026-05-06 2:10 ` 李志 [this message]
2026-05-12 5:39 ` Re: " 李志
2026-05-12 23:13 ` Jakub Kicinski
2026-05-14 2:25 ` 李志
2026-04-27 7:25 ` [PATCH net-next v7 3/4] dt-bindings: mfd: syscon: add ESWIN EIC7700 compatible lizhi2
2026-04-27 19:05 ` Conor Dooley
2026-04-27 7:26 ` [PATCH net-next v7 4/4] riscv: dts: eswin: eic7700-hifive-premier-p550: enable Ethernet controller lizhi2
2026-04-29 1:41 ` Andrew Lunn
2026-04-30 7:05 ` 李志
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38d052b7.7a70.19dfb0d782b.Coremail.lizhi2@eswincomputing.com \
--to=lizhi2@eswincomputing$(echo .)com \
--cc=alex@ghiti$(echo .)fr \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linmin@eswincomputing$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ningyu@eswincomputing$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=pinkesh.vaghela@einfochips$(echo .)com \
--cc=pjw@kernel$(echo .)org \
--cc=pritesh.patel@einfochips$(echo .)com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
--cc=robh@kernel$(echo .)org \
--cc=weishangjuan@eswincomputing$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox