From: Alexander Lobakin <aleksander.lobakin@intel•com>
To: Lorenzo Bianconi <lorenzo@kernel•org>
Cc: Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
<linux-arm-kernel@lists•infradead.org>,
<linux-mediatek@lists•infradead.org>, <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next] net: airoha: Report extack error to the user if airoha_tc_htb_modify_queue() fails
Date: Wed, 3 Jun 2026 16:05:58 +0200 [thread overview]
Message-ID: <3f32190f-760b-46fa-b705-3795d452bb04@intel.com> (raw)
In-Reply-To: <20260603-airoha_tc_htb_modify_queue-err-message-v1-1-33ec3ab997d9@kernel.org>
From: Lorenzo Bianconi <lorenzo@kernel•org>
Date: Wed, 03 Jun 2026 12:30:01 +0200
> Report an extack error message in airoha_tc_htb_modify_queue routine if
> airoha_qdma_set_tx_rate_limit() fails.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel•org>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel•com>
> ---
> drivers/net/ethernet/airoha/airoha_eth.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c
> index 6574901ebd19..d0d13f01e50f 100644
> --- a/drivers/net/ethernet/airoha/airoha_eth.c
> +++ b/drivers/net/ethernet/airoha/airoha_eth.c
> @@ -2605,13 +2605,19 @@ static int airoha_tc_htb_modify_queue(struct net_device *dev,
> {
> u32 channel = TC_H_MIN(opt->classid) % AIROHA_NUM_QOS_CHANNELS;
> u32 rate = div_u64(opt->rate, 1000) << 3; /* kbps */
> + int err;
>
> if (opt->parent_classid != TC_HTB_CLASSID_ROOT) {
> NL_SET_ERR_MSG_MOD(opt->extack, "invalid parent classid");
> return -EINVAL;
> }
>
> - return airoha_qdma_set_tx_rate_limit(dev, channel, rate, opt->quantum);
> + err = airoha_qdma_set_tx_rate_limit(dev, channel, rate, opt->quantum);
> + if (err)
> + NL_SET_ERR_MSG_MOD(opt->extack,
> + "failed configuring htb offload");
> +
> + return err;
> }
>
> static int airoha_tc_htb_alloc_leaf_queue(struct net_device *netdev,
Thanks,
Olek
next prev parent reply other threads:[~2026-06-03 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 10:30 [PATCH net-next] net: airoha: Report extack error to the user if airoha_tc_htb_modify_queue() fails Lorenzo Bianconi
2026-06-03 14:05 ` Alexander Lobakin [this message]
2026-06-05 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f32190f-760b-46fa-b705-3795d452bb04@intel.com \
--to=aleksander.lobakin@intel$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=lorenzo@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox