From: Keerthy <j-keerthy@ti•com>
To: Tony Lindgren <tony@atomide•com>, <linux-omap@vger•kernel.org>
Cc: Nishanth Menon <nm@ti•com>, Tero Kristo <t-kristo@ti•com>,
Vignesh Raghavendra <vigneshr@ti•com>,
Dave Gerlach <d-gerlach@ti•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
linux-kernel@vger•kernel.org, "Andrew F . Davis" <afd@ti•com>,
Peter Ujfalusi <peter.ujfalusi@ti•com>,
Faiz Abbas <faiz_abbas@ti•com>,
linux-arm-kernel@lists•infradead.org,
Roger Quadros <rogerq@ti•com>
Subject: Re: [PATCH] bus: ti-sysc: Remove unpaired sysc_clkdm_deny_idle()
Date: Mon, 9 Sep 2019 07:27:12 +0530 [thread overview]
Message-ID: <40e5c2a1-3682-584a-4eb9-4d96901bbfda@ti.com> (raw)
In-Reply-To: <20190906200154.6510-1-tony@atomide.com>
On 07/09/19 1:31 AM, Tony Lindgren wrote:
> Commit d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle
> quirks") fixed handling for no-idle quirk modules that are not enabled
> by the bootloader.
>
> But it also caused unpaired clockdomain calls that won't allow idling
> the system. That's because clkdm_allow_idle_nolock() and
> clkdm_deny_idle_nolock() have usage count with clkdm->forcewake_count.
>
> Let's drop the unpaired sysc_clkdm_deny_idle() to fix idling of devices.
Tested-by: Keerthy <j-keerthy@ti•com>
I believe still the previous fix [1] for nfs boot is still not on
linux-next. Are you planning on more testing or it will be queued as fixes?
[1] https://lkml.org/lkml/2019/9/5/616
- Keerthy
>
> Fixes: d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle quirks")
> Cc: Keerthy <j-keerthy@ti•com>
> Cc: Vignesh Raghavendra <vigneshr@ti•com>
> Signed-off-by: Tony Lindgren <tony@atomide•com>
> ---
> drivers/bus/ti-sysc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -2363,7 +2363,6 @@ static void ti_sysc_idle(struct work_struct *work)
> */
> if (ddata->cfg.quirks & (SYSC_QUIRK_NO_IDLE |
> SYSC_QUIRK_NO_IDLE_ON_INIT)) {
> - sysc_clkdm_deny_idle(ddata);
> sysc_disable_main_clocks(ddata);
> sysc_disable_opt_clocks(ddata);
> sysc_clkdm_allow_idle(ddata);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-09 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 20:01 [PATCH] bus: ti-sysc: Remove unpaired sysc_clkdm_deny_idle() Tony Lindgren
2019-09-09 1:57 ` Keerthy [this message]
2019-09-09 16:19 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40e5c2a1-3682-584a-4eb9-4d96901bbfda@ti.com \
--to=j-keerthy@ti$(echo .)com \
--cc=afd@ti$(echo .)com \
--cc=d-gerlach@ti$(echo .)com \
--cc=faiz_abbas@ti$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=nm@ti$(echo .)com \
--cc=peter.ujfalusi@ti$(echo .)com \
--cc=rogerq@ti$(echo .)com \
--cc=t-kristo@ti$(echo .)com \
--cc=tony@atomide$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox