From: Tero Kristo <t-kristo@ti•com>
To: Tony Lindgren <tony@atomide•com>
Cc: devicetree@vger•kernel.org, linux-omap@vger•kernel.org,
robh+dt@kernel•org, p.zabel@pengutronix•de, ssantosh@kernel•org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCHv5 10/10] ARM: OMAP2+: pdata-quirks: add PRM data for reset support
Date: Thu, 12 Sep 2019 23:09:21 +0300 [thread overview]
Message-ID: <4103d986-20fa-0dce-df6b-b0955ceabd74@ti.com> (raw)
In-Reply-To: <20190912170953.GT52127@atomide.com>
On 12/09/2019 20:09, Tony Lindgren wrote:
> * Tero Kristo <t-kristo@ti•com> [190912 11:40]:
>> @@ -565,6 +566,12 @@ void omap_pcs_legacy_init(int irq, void (*rearm)(void))
>> pcs_pdata.rearm = rearm;
>> }
>>
>> +static struct ti_prm_platform_data ti_prm_pdata = {
>> + .clkdm_deny_idle = clkdm_deny_idle,
>> + .clkdm_allow_idle = clkdm_allow_idle,
>> + .clkdm_lookup = clkdm_lookup,
>> +};
>> +
>> /*
>> * GPIOs for TWL are initialized by the I2C bus and need custom
>> * handing until DSS has device tree bindings.
>> @@ -664,6 +671,11 @@ static struct of_dev_auxdata omap_auxdata_lookup[] = {
>> /* Common auxdata */
>> OF_DEV_AUXDATA("ti,sysc", 0, NULL, &ti_sysc_pdata),
>> OF_DEV_AUXDATA("pinctrl-single", 0, NULL, &pcs_pdata),
>> + OF_DEV_AUXDATA("ti,omap4-prm-inst", 0, NULL, &ti_prm_pdata),
>> + OF_DEV_AUXDATA("ti,omap5-prm-inst", 0, NULL, &ti_prm_pdata),
>> + OF_DEV_AUXDATA("ti,dra7-prm-inst", 0, NULL, &ti_prm_pdata),
>> + OF_DEV_AUXDATA("ti,am3-prm-inst", 0, NULL, &ti_prm_pdata),
>> + OF_DEV_AUXDATA("ti,am4-prm-inst", 0, NULL, &ti_prm_pdata),
>> { /* sentinel */ },
>> };
>
> Hmm I think I already commented on this.. Just one entry please:
>
> OF_DEV_AUXDATA("ti,omap-prm-inst", 0, NULL, &ti_prm_pdata),
>
> As the auxdata is the same for all of them. Note that all the
> dts files need to have also the generic compatible
> "ti,omap-prm-inst" after the SoC specific one.
Ok that should be fine, sorry for missing it out. I can update this in
the next rev, just need to update the dt binding also.
-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-12 20:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 11:39 [PATCHv5 00/10] soc: ti: add OMAP PRM driver (for reset) Tero Kristo
2019-09-12 11:39 ` [PATCHv5 01/10] dt-bindings: omap: add new binding for PRM instances Tero Kristo
2019-09-17 17:48 ` Rob Herring
2019-09-19 12:30 ` [PATCHv6 " Tero Kristo
2019-09-19 19:54 ` Rob Herring
2019-09-20 14:26 ` Tony Lindgren
2019-09-12 11:39 ` [PATCHv5 02/10] soc: ti: add initial PRM driver with reset control support Tero Kristo
2019-09-12 11:39 ` [PATCHv5 03/10] soc: ti: omap-prm: poll for reset complete during de-assert Tero Kristo
2019-09-12 11:39 ` [PATCHv5 04/10] soc: ti: omap-prm: add support for denying idle for reset clockdomain Tero Kristo
2019-09-12 11:39 ` [PATCHv5 05/10] soc: ti: omap-prm: add omap4 PRM data Tero Kristo
2019-09-12 11:39 ` [PATCHv5 06/10] soc: ti: omap-prm: add data for am33xx Tero Kristo
2019-09-12 11:39 ` [PATCHv5 07/10] soc: ti: omap-prm: add dra7 PRM data Tero Kristo
2019-09-12 11:39 ` [PATCHv5 08/10] soc: ti: omap-prm: add am4 " Tero Kristo
2019-09-12 11:39 ` [PATCHv5 09/10] soc: ti: omap-prm: add omap5 " Tero Kristo
2019-09-12 11:39 ` [PATCHv5 10/10] ARM: OMAP2+: pdata-quirks: add PRM data for reset support Tero Kristo
2019-09-12 17:09 ` Tony Lindgren
2019-09-12 20:09 ` Tero Kristo [this message]
2019-09-19 12:32 ` [PATCHv6 " Tero Kristo
2019-09-20 14:26 ` Tony Lindgren
2019-09-20 14:28 ` [PATCHv5 00/10] soc: ti: add OMAP PRM driver (for reset) Tony Lindgren
2019-09-20 19:19 ` santosh.shilimkar
2019-09-23 17:47 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4103d986-20fa-0dce-df6b-b0955ceabd74@ti.com \
--to=t-kristo@ti$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=robh+dt@kernel$(echo .)org \
--cc=ssantosh@kernel$(echo .)org \
--cc=tony@atomide$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox