From: Leon Hwang <leon.hwang@linux•dev>
To: Chris Mason <clm@meta•com>, bot+bpf-ci@kernel•org, bpf@vger•kernel.org
Cc: ast@kernel•org, daniel@iogearbox•net, andrii@kernel•org,
martin.lau@linux•dev, eddyz87@gmail•com, song@kernel•org,
yonghong.song@linux•dev, john.fastabend@gmail•com,
kpsingh@kernel•org, sdf@fomichev•me, haoluo@google•com,
jolsa@kernel•org, puranjay@kernel•org, xukuohai@huaweicloud•com,
catalin.marinas@arm•com, will@kernel•org, shuah@kernel•org,
menglong8.dong@gmail•com, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, linux-kselftest@vger•kernel.org,
kernel-patches-bot@fb•com, martin.lau@kernel•org,
ihor.solodrai@linux•dev
Subject: Re: [PATCH bpf-next v2 1/3] bpf: Add bpf_arch_supports_fsession()
Date: Wed, 28 Jan 2026 23:40:26 +0800 [thread overview]
Message-ID: <4295e99d-8638-4cff-90e2-e1f5c2452b52@linux.dev> (raw)
In-Reply-To: <65231eeb-1f00-4af2-9234-a290ea3f6585@meta.com>
On 2026/1/28 23:35, Chris Mason wrote:
>
>
> On 1/28/26 10:26 AM, bot+bpf-ci@kernel•org wrote:
>>> diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c
>>> index 5a075e06cf..070ba80e39 100644
>>> --- a/arch/x86/net/bpf_jit_comp.c
>>> +++ b/arch/x86/net/bpf_jit_comp.c
>>> @@ -4112,3 +4112,8 @@ bool bpf_jit_supports_timed_may_goto(void)
>>> {
>>> return true;
>>> }
>>> +
>>> +bool bpf_jit_supports_fsession(void)
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^
>> This is the actual function name in the code.
>
> Ihor, I think the script parsing review-inline.txt chopped off the
> part of the review where AI was complaining about the commit message?
>
> commit f636685cc0b05bb758bb58729cc65dde79ac7108
> Author: Leon Hwang <leon.hwang@linux•dev>
>
> bpf: Add bpf_arch_supports_fsession()
>
> This commit adds architecture-specific gating for fsession programs,
> returning -EOPNOTSUPP when the architecture does not implement fsession
> support, instead of failing at runtime with -EFAULT.
>
>> bpf: Add bpf_arch_supports_fsession()
>
> The commit subject references bpf_arch_supports_fsession(), but the
> actual function implemented is named bpf_jit_supports_fsession().
>
>> Introduce bpf_arch_supports_fsession() to explicitly gate fsession usage
>> based on architecture support.
>
> Similarly, the commit body describes bpf_arch_supports_fsession(), while
> the code uses bpf_jit_supports_fsession().
>
> Should the commit message be updated to match the actual function name?
> The function follows the existing bpf_jit_supports_*() naming convention
> used by similar functions in the codebase.
>
Correct, in commit message, the function should be
bpf_jit_supports_fsession(), too.
Thanks,
Leon
next prev parent reply other threads:[~2026-01-28 15:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 15:01 [PATCH bpf-next v2 0/3] bpf, arm64: Add fsession support Leon Hwang
2026-01-28 15:01 ` [PATCH bpf-next v2 1/3] bpf: Add bpf_arch_supports_fsession() Leon Hwang
2026-01-28 15:25 ` Leon Hwang
2026-01-28 15:26 ` bot+bpf-ci
2026-01-28 15:32 ` Leon Hwang
2026-01-28 15:35 ` Chris Mason
2026-01-28 15:40 ` Leon Hwang [this message]
2026-01-28 17:33 ` Ihor Solodrai
2026-01-28 18:49 ` Alexei Starovoitov
2026-01-28 19:08 ` Ihor Solodrai
2026-01-28 20:31 ` Alexei Starovoitov
2026-01-29 1:29 ` Menglong Dong
2026-01-29 2:14 ` Leon Hwang
2026-01-28 15:01 ` [PATCH bpf-next v2 2/3] bpf, arm64: Add fsession support Leon Hwang
2026-01-30 20:12 ` Alexei Starovoitov
2026-01-28 15:01 ` [PATCH bpf-next v2 3/3] bpf/selftests: Enable get_func_args and get_func_ip tests on arm64 Leon Hwang
2026-01-29 1:13 ` Menglong Dong
2026-01-28 19:32 ` [PATCH bpf-next v2 0/3] bpf, arm64: Add fsession support Puranjay Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4295e99d-8638-4cff-90e2-e1f5c2452b52@linux.dev \
--to=leon.hwang@linux$(echo .)dev \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bot+bpf-ci@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=clm@meta$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=eddyz87@gmail$(echo .)com \
--cc=haoluo@google$(echo .)com \
--cc=ihor.solodrai@linux$(echo .)dev \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kernel-patches-bot@fb$(echo .)com \
--cc=kpsingh@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=martin.lau@kernel$(echo .)org \
--cc=martin.lau@linux$(echo .)dev \
--cc=menglong8.dong@gmail$(echo .)com \
--cc=puranjay@kernel$(echo .)org \
--cc=sdf@fomichev$(echo .)me \
--cc=shuah@kernel$(echo .)org \
--cc=song@kernel$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=xukuohai@huaweicloud$(echo .)com \
--cc=yonghong.song@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox