public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: icenowy@aosc•xyz (Icenowy Zheng)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
Date: Thu, 25 Aug 2016 22:53:22 +0800	[thread overview]
Message-ID: <438381472136802@web24g.yandex.ru> (raw)
In-Reply-To: <6580ba1b-f542-58d4-9f0a-fdd8e9b86092@redhat.com>



25.08.2016, 22:18, "Hans de Goede" <hdegoede@redhat•com>:
> Hi,
>
> On 25-08-16 16:12, Icenowy Zheng wrote:
>> ?25.08.2016, 16:03, "Maxime Ripard" <maxime.ripard@free-electrons•com>:
>>> ?Hi,
>>>
>>> ?On Thu, Aug 25, 2016 at 02:57:24PM +0800, Icenowy Zheng wrote:
>>>> ??>>>> diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
>>>> ??>>>> index 78823d8..3ac22d4 100644
>>>> ??>>>> --- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
>>>> ??>>>> +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
>>>> ??>>>> @@ -48,6 +48,10 @@
>>>> ??>>>> model = "INet-D978 Rev 02";
>>>> ??>>>> compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33";
>>>> ??>>>>
>>>> ??>>>> + aliases {
>>>> ??>>>> + serial1 = &uart1;
>>>> ??>>>> + };
>>>> ??>>>> +
>>>> ??>>>
>>>> ??>>> Is there any other UART in the system?
>>>> ??>>
>>>> ??>> serial0 is defined in sun8i-reference-design-tablet.dtsi, as r_uart.
>>>> ??>
>>>> ??> If your board does not have r_uart pads, then the right thing to do
>>>> ??> would be to disable it. You can then have uart1 as serial0.
>>>>
>>>> ??I don't know it. The RX/TX is wired on PF2/PF4 on the board (UART0 muxed with
>>>> ??MMC)
>>>
>>> ?Then you don't support it and you need to disable it.
>>>
>>>> ??But many codes will require a ttyS0 as console... So I think the
>>>> ??bluetooth should be located at ttyS1...
>>>
>>> ?Most of them would use /dev/console anyway. What do you have in mind?
>>
>> ?As a general configuration, /dev/ttyS0 will be indicated as the default console=
>> ?value... (Otherwise more boards will fail)
>>
>> ?Or maybe we can specify uart0 as serial0, and leave it as disabled? (Thus if the
>> ?debug port is needed, we can easily apply a overlay with &mmc0 status as disabled,
>> ?and &uart0 status as okay)
>>
>> ?On all my A33 boards, the official boot0, u-boot all uses uart0 as debugging port.
>
> If no uart is available (and being muxed with the mmc counts as not being available)
> then you should not have any serial alias in the dts.
>
> In u-boot you need to use:
>
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
>
> In the defconfig in this case, otherwise u-boot is going to be unhappy about
> not having a serial console.

It's not the problem.

Can I have no ttyS0 and just make bluetooth ttyS1?

>
> Regards,
>
> Hans

  parent reply	other threads:[~2016-08-25 14:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23  6:44 [PATCH 0/2] Add support for iNet D978 Rev2 board Icenowy Zheng
2016-08-23  6:44 ` [PATCH 1/2] ARM: dts: sun8i: Add dts file for inet-d978_rev2 tablets Icenowy Zheng
2016-08-24 19:32   ` Maxime Ripard
2016-08-24 23:57     ` Icenowy Zheng
2016-08-25  7:35       ` Maxime Ripard
2016-08-23  6:44 ` [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board Icenowy Zheng
2016-08-24 19:36   ` Maxime Ripard
2016-08-24 23:58     ` Icenowy Zheng
2016-08-25  4:40       ` Chen-Yu Tsai
2016-08-25  6:57         ` Icenowy Zheng
2016-08-25  8:03           ` Maxime Ripard
2016-08-25 14:12             ` Icenowy Zheng
2016-08-25 14:17               ` Hans de Goede
2016-08-25 14:53                 ` Icenowy Zheng
2016-08-25 14:53                 ` Icenowy Zheng [this message]
2016-08-25 15:13                   ` Hans de Goede
2016-08-25 15:29                     ` Icenowy Zheng
2016-08-25 20:47               ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=438381472136802@web24g.yandex.ru \
    --to=icenowy@aosc$(echo .)xyz \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox