From: Krzysztof Kozlowski <krzk@kernel•org>
To: Alexey Klimov <alexey.klimov@linaro•org>,
Sam Protsenko <semen.protsenko@linaro•org>,
Tudor Ambarus <tudor.ambarus@linaro•org>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Alim Akhtar <alim.akhtar@samsung•com>
Cc: Peter Griffin <peter.griffin@linaro•org>,
linux-samsung-soc@vger•kernel.org, devicetree@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: firmware: google,gs101-acpm-ipc: document Exynos850 compatible
Date: Sun, 24 May 2026 21:45:08 +0200 [thread overview]
Message-ID: <453e852b-1134-4404-999e-125d712188dd@kernel.org> (raw)
In-Reply-To: <20260513-exynos850-acpm-firmware-support-v1-1-3858d097e433@linaro.org>
On 13/05/2026 01:12, Alexey Klimov wrote:
> The Exynos850 SoC incorporates an APM co-processor. Communication with
> this hardware block is done using the ACPM protocol, which handles IPC
> messages for clocks, power, thermal management and PMIC control.
>
> Dedicated compatible string is required for the Exynos850 because
> its firmware utilizes a different initialisation data base offset
> (0x7000) compared to the existing GS101 implementation (0xa000).
This is good reason/explanation, but open the binding please - you will
see several specific children, e.g. S2MPG10. You need to be very
explicit in commit msg that your Exynos850 is always fitted with these
PMIcs. If not, then you need some other compatibles, because binding
should be complete.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-24 19:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 23:12 [PATCH 0/2] Initial Exynos850 ACPM support for exynos-acpm Alexey Klimov
2026-05-12 23:12 ` [PATCH 1/2] dt-bindings: firmware: google,gs101-acpm-ipc: document Exynos850 compatible Alexey Klimov
2026-05-14 14:46 ` Tudor Ambarus
2026-05-18 11:30 ` Alexey Klimov
2026-05-24 19:45 ` Krzysztof Kozlowski [this message]
2026-05-12 23:12 ` [PATCH 2/2] firmware: samsung: acpm: add Exynos850 support Alexey Klimov
2026-05-18 10:27 ` Tudor Ambarus
2026-05-18 10:46 ` Krzysztof Kozlowski
2026-05-18 11:11 ` Tudor Ambarus
2026-05-18 10:46 ` Alexey Klimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453e852b-1134-4404-999e-125d712188dd@kernel.org \
--to=krzk@kernel$(echo .)org \
--cc=alexey.klimov@linaro$(echo .)org \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=peter.griffin@linaro$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=semen.protsenko@linaro$(echo .)org \
--cc=tudor.ambarus@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox