From: oneukum@suse•de (Oliver Neukum)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH v1 1/6] USB: HCD: support giveback of URB in tasklet context
Date: Fri, 21 Jun 2013 10:33:46 +0200 [thread overview]
Message-ID: <4558223.ViRy5S2mR9@linux-5eaq.site> (raw)
In-Reply-To: <CACVXFVMdxtd2fcwNE_YrfwG0Ksq67ww_Ar9A6fCGSr442gWaag@mail.gmail.com>
On Friday 21 June 2013 09:12:38 Ming Lei wrote:
> >> This should be enough since during remove path usbcore will wait for all
> >> URBs' completion which is only triggered by tasklet, so once all URBs are
> >> finished, the tasklet list has been empty already.
> >
> > No, usbcore only waits until the urb_list for each endpoint is empty.
> > It doesn't keep track of the individual URB completions. Look at
> > usb_hcd_flush_endpoint() and you'll see.
>
> But, if URBs still aren't completed after usb_disconnect(), it should be
> bug of usbcore or driver, shouldn't it?
A driver cannot know what caused the call to disconnect(). That includes
driver unbind. Doing IO to a device that another driver may be bound to
is certainly a bug.
Nevertheless it usually works and it is desirable to keep that behavior.
Regards
Oliver
next prev parent reply other threads:[~2013-06-21 8:33 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 15:03 [RFC PATCH v1 0/6] USB: HCD/EHCI: giveback of URB in tasklet context Ming Lei
2013-06-18 15:03 ` [RFC PATCH v1 1/6] USB: HCD: support " Ming Lei
2013-06-18 16:05 ` Alan Stern
2013-06-19 2:59 ` Ming Lei
2013-06-19 11:50 ` Ming Lei
2013-06-19 15:37 ` Alan Stern
2013-06-20 1:50 ` Ming Lei
2013-06-20 14:59 ` Alan Stern
2013-06-20 15:13 ` Ming Lei
2013-06-20 16:52 ` Alan Stern
2013-06-21 1:12 ` Ming Lei
2013-06-21 4:46 ` Ming Lei
2013-06-21 5:13 ` Ming Lei
2013-06-21 8:33 ` Oliver Neukum [this message]
2013-06-21 9:13 ` Ming Lei
2013-06-21 9:20 ` Oliver Neukum
2013-06-21 9:43 ` Ming Lei
2013-06-21 10:09 ` Ming Lei
2013-06-21 14:48 ` Alan Stern
2013-06-21 16:12 ` Ming Lei
2013-06-18 15:03 ` [RFC PATCH v1 2/6] USB: disable IRQs deliberately when calling complete() Ming Lei
2013-06-18 15:13 ` Sergei Shtylyov
2013-06-18 16:36 ` Alan Stern
2013-06-19 3:02 ` Ming Lei
2013-06-19 15:30 ` Alan Stern
2013-06-18 15:03 ` [RFC PATCH v1 3/6] USB: URB documentation: claim complete() may be run with IRQs enabled Ming Lei
2013-06-18 16:42 ` Alan Stern
2013-06-19 3:06 ` Ming Lei
2013-06-18 15:03 ` [RFC PATCH v1 4/6] USB: EHCI: don't release ehci->lock if URB giveback in tasklet context Ming Lei
2013-06-18 16:43 ` Alan Stern
2013-06-19 3:13 ` Ming Lei
2013-06-19 15:47 ` Alan Stern
2013-06-20 1:53 ` Ming Lei
2013-06-18 15:03 ` [RFC PATCH v1 5/6] USB: EHCI: improve interrupt qh unlink Ming Lei
2013-06-18 16:51 ` Alan Stern
2013-06-19 3:36 ` Ming Lei
2013-06-19 15:44 ` Alan Stern
2013-06-20 6:05 ` Ming Lei
2013-06-21 20:16 ` Alan Stern
2013-06-24 4:55 ` Ming Lei
2013-06-18 15:03 ` [RFC PATCH v1 6/6] USB: EHCI: support running URB giveback in tasklet context Ming Lei
2013-06-18 16:55 ` Alan Stern
2013-06-19 3:39 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4558223.ViRy5S2mR9@linux-5eaq.site \
--to=oneukum@suse$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox