From: laurent.pinchart@ideasonboard•com (Laurent Pinchart)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 1/4] [media] exynos-scaler: Add DT bindings for SCALER driver
Date: Wed, 19 Mar 2014 12:31:01 +0100 [thread overview]
Message-ID: <4637278.9G3gGkQ5GA@avalon> (raw)
In-Reply-To: <1395213196-25972-2-git-send-email-shaik.ameer@samsung.com>
Hi Shaik,
Thank you for the patch.
On Wednesday 19 March 2014 12:43:13 Shaik Ameer Basha wrote:
> This patch adds the DT binding documentation for the Exynos5420/5410
> based SCALER device driver.
>
> Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung•com>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung•com>
> ---
> .../devicetree/bindings/media/exynos5-scaler.txt | 24 +++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/media/exynos5-scaler.txt
>
> diff --git a/Documentation/devicetree/bindings/media/exynos5-scaler.txt
> b/Documentation/devicetree/bindings/media/exynos5-scaler.txt new file mode
> 100644
> index 0000000..e1dd465
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/exynos5-scaler.txt
> @@ -0,0 +1,24 @@
> +* Samsung Exynos5 SCALER device
> +
> +SCALER is used for scaling, blending, color fill and color space
> +conversion on EXYNOS[5420/5410] SoCs.
> +
> +Required properties:
> +- compatible: should be "samsung,exynos5420-scaler" or
> + "samsung,exynos5410-scaler"
> +- reg: should contain SCALER physical address location and length
> +- interrupts: should contain SCALER interrupt specifier
> +- clocks: should contain the SCALER clock phandle and specifier pair for
> + each clock listed in clock-names property, according to
> + the common clock bindings
> +- clock-names: should contain exactly one entry
> + - "scaler" - IP bus clock
I'm not too familiar with the Exynos platform, but wouldn't it make sense to
use a common name across IP cores for interface and function clocks ?
> +Example:
> + scaler_0: scaler at 12800000 {
> + compatible = "samsung,exynos5420-scaler";
> + reg = <0x12800000 0x1000>;
> + interrupts = <0 220 0>;
> + clocks = <&clock 381>;
> + clock-names = "scaler";
> + };
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-03-19 11:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 7:13 [PATCH v6 0/4] Exynos5 Series SCALER Driver Shaik Ameer Basha
2014-03-19 7:13 ` [PATCH v6 1/4] [media] exynos-scaler: Add DT bindings for SCALER driver Shaik Ameer Basha
2014-03-19 11:31 ` Laurent Pinchart [this message]
2014-03-19 11:55 ` Sylwester Nawrocki
2014-03-19 11:59 ` Laurent Pinchart
2014-03-19 12:33 ` Sylwester Nawrocki
2014-03-19 12:02 ` Tomasz Figa
2014-03-19 7:13 ` [PATCH v6 2/4] [media] exynos-scaler: Add new driver for Exynos5 SCALER Shaik Ameer Basha
2014-03-19 7:13 ` [PATCH v6 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver Shaik Ameer Basha
2014-03-19 7:49 ` Hans Verkuil
2014-03-21 5:00 ` Shaik Ameer Basha
2014-03-19 7:13 ` [PATCH v6 4/4] [media] exynos-scaler: Add core " Shaik Ameer Basha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4637278.9G3gGkQ5GA@avalon \
--to=laurent.pinchart@ideasonboard$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox