From: "Stefan Riedmüller" <s.riedmueller@phytec•de>
To: Shawn Guo <shawnguo@kernel•org>
Cc: Marco Felsch <m.felsch@pengutronix•de>,
chf.fritz@googlemail•com, robh+dt@kernel•org,
kernel@pengutronix•de, c.hemp@phytec•de, contact@stefanchrist•eu,
s.christ@phytec•de, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v4] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
Date: Wed, 11 Mar 2020 09:18:42 +0100 [thread overview]
Message-ID: <486b3eda-00a3-80e6-ceb4-dcb0983f2101@phytec.de> (raw)
In-Reply-To: <20200311073248.GP29269@dragon>
Hi Shawn,
On 11.03.20 08:33, Shawn Guo wrote:
> On Thu, Feb 27, 2020 at 12:02:46PM +0100, Marco Felsch wrote:
>> The current set minimum voltage of 730000µV seems to be wrong. I don't
>> know the document which specifies that but the imx6qdl datasheets says
>> that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
>> lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).
>
> Stefan,
>
> Any comment on this change?
looks good to me. Thanks for asking.
Reviewed-by: Stefan Riedmueller <s.riedmueller@phytec•de>
Regards,
Stefan
>
> Shawn
>
>>
>> Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
>> Signed-off-by: Marco Felsch <m.felsch@pengutronix•de>
>> ---
>> v4:
>> - rebased ontop of v5.6-rc1
>> v3:
>> - fix commit message
>> v2:
>> - use ldo bypassed values
>>
>> arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> index 4d18952658f8..77d871340eb7 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> @@ -112,7 +112,7 @@
>> regulators {
>> vdd_arm: buck1 {
>> regulator-name = "vdd_arm";
>> - regulator-min-microvolt = <730000>;
>> + regulator-min-microvolt = <925000>;
>> regulator-max-microvolt = <1380000>;
>> regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>;
>> regulator-always-on;
>> @@ -120,7 +120,7 @@
>>
>> vdd_soc: buck2 {
>> regulator-name = "vdd_soc";
>> - regulator-min-microvolt = <730000>;
>> + regulator-min-microvolt = <1150000>;
>> regulator-max-microvolt = <1380000>;
>> regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>;
>> regulator-always-on;
>> --
>> 2.20.1
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-11 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 11:02 [PATCH v4] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Marco Felsch
2020-03-11 7:33 ` Shawn Guo
2020-03-11 8:18 ` Stefan Riedmüller [this message]
2020-03-11 8:28 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486b3eda-00a3-80e6-ceb4-dcb0983f2101@phytec.de \
--to=s.riedmueller@phytec$(echo .)de \
--cc=c.hemp@phytec$(echo .)de \
--cc=chf.fritz@googlemail$(echo .)com \
--cc=contact@stefanchrist$(echo .)eu \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=m.felsch@pengutronix$(echo .)de \
--cc=robh+dt@kernel$(echo .)org \
--cc=s.christ@phytec$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox