From: wg@grandegger•com (Wolfgang Grandegger)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] at91_can: add driver for Atmel's CAN controller on AT91SAM9263
Date: Wed, 16 Sep 2009 12:07:48 +0200 [thread overview]
Message-ID: <4AB0B8F4.50301@grandegger.com> (raw)
In-Reply-To: <1253094405-3216-4-git-send-email-mkl@pengutronix.de>
Marc Kleine-Budde wrote:
> This patch add the driver for the SoC CAN controller in Atmel's AT91SAM9263.
>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix•de>
I already reviewed at91_can.c on the Socket-CAN ML and it's almost OK
from the Socket-CAN point of view. I just realized two minor issues:
> ---
> drivers/net/can/Kconfig | 6 +
> drivers/net/can/Makefile | 1 +
> drivers/net/can/at91_can.c | 1177 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 1184 insertions(+), 0 deletions(-)
> create mode 100644 drivers/net/can/at91_can.c
>
> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
> index 0900743..b6d2af1 100644
> --- a/drivers/net/can/Kconfig
> +++ b/drivers/net/can/Kconfig
> @@ -82,6 +82,12 @@ config CAN_KVASER_PCI
> This driver is for the the PCIcanx and PCIcan cards (1, 2 or
> 4 channel) from Kvaser (http://www.kvaser.com).
>
> +config CAN_AT91
> + tristate "Atmel AT91 onchip CAN controller"
> + depends on CAN && ARCH_AT91SAM9263
It should depend on CAN_DEV because it used the CAN device driver interface.
> + ---help---
> + This is a driver for the SoC CAN controller in Atmel's AT91SAM9263.
> +
> config CAN_DEBUG_DEVICES
> bool "CAN devices debugging messages"
> depends on CAN
> diff --git a/drivers/net/can/Makefile b/drivers/net/can/Makefile
> index 523a941..3a54a12 100644
> --- a/drivers/net/can/Makefile
> +++ b/drivers/net/can/Makefile
> @@ -8,5 +8,6 @@ obj-$(CONFIG_CAN_DEV) += can-dev.o
> can-dev-y := dev.o
>
> obj-$(CONFIG_CAN_SJA1000) += sja1000/
> +obj-$(CONFIG_CAN_AT91) += at91_can.o
>
> ccflags-$(CONFIG_CAN_DEBUG_DEVICES) := -DDEBUG
> diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c
> new file mode 100644
> index 0000000..cd1e8cb
> --- /dev/null
> +++ b/drivers/net/can/at91_can.c
> @@ -0,0 +1,1177 @@
> +/*
> + * at91_can.c - CAN network driver for AT91 SoC CAN controller
> + *
> + * (C) 2007 by Hans J. Koch <hjk@linutronix•de>
> + * (C) 2008, 2009 by Marc Kleine-Budde <kernel@pengutronix•de>
> + *
> + * This software may be distributed under the terms of the GNU General
> + * Public License ("GPL") version 2 as distributed in the 'COPYING'
> + * file from the main directory of the linux kernel source.
> + *
> + * Send feedback to <socketcan-users@lists•berlios.de>
This driver uses platform data. Could you please add some description on
how they should be used, e.g. like for the MCP251x:
* Your platform definition file should specify something like:
*
* static struct mcp251x_platform_data mcp251x_info = {
* .oscillator_frequency = 8000000,
* .board_specific_setup = &mcp251x_setup,
* .model = CAN_MCP251X_MCP2510,
* .power_enable = mcp251x_power_enable,
* .transceiver_enable = NULL,
* };
*
* static struct spi_board_info spi_board_info[] = {
* {
* .modalias = "mcp251x",
* .platform_data = &mcp251x_info,
* .irq = IRQ_EINT13,
* .max_speed_hz = 2*1000*1000,
* .chip_select = 2,
* },
* };
*
* Please see mcp251x.h for a description of the fields in
* struct mcp251x_platform_data.
I find that really useful.
Wolfgang.
next prev parent reply other threads:[~2009-09-16 10:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 9:46 [PATCH 0/3] at91_can: add support for Atmel's CAN controller on AT91SAM9263 Marc Kleine-Budde
2009-09-16 9:46 ` [PATCH 1/3] at91sam9263: add at91_can device to generic device definition Marc Kleine-Budde
2009-09-16 9:46 ` [PATCH 2/3] at91sam9263ek: activate at91 CAN controller Marc Kleine-Budde
2009-09-16 9:46 ` [PATCH 3/3] at91_can: add driver for Atmel's CAN controller on AT91SAM9263 Marc Kleine-Budde
2009-09-16 10:07 ` Wolfgang Grandegger [this message]
2009-09-16 10:45 ` Marc Kleine-Budde
2009-09-16 10:47 ` Marc Kleine-Budde
2009-09-21 21:23 ` [PATCH 1/3] at91sam9263: add at91_can device to generic device definition Andrew Victor
2009-09-21 21:30 ` Marc Kleine-Budde
-- strict thread matches above, loose matches on Subject: below --
2009-09-17 9:37 No subject Marc Kleine-Budde
2009-09-17 9:37 ` [PATCH 1/3] at91sam9263: add at91_can device to generic device definition Marc Kleine-Budde
2009-09-17 9:37 ` [PATCH 2/3] at91sam9263ek: activate at91 CAN controller Marc Kleine-Budde
2009-09-17 9:37 ` [PATCH 3/3] at91_can: add driver for Atmel's CAN controller on AT91SAM9263 Marc Kleine-Budde
2009-09-17 9:48 ` Wolfgang Grandegger
2009-09-22 22:09 ` David Miller
2009-09-21 21:44 ` Andrew Victor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB0B8F4.50301@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox