From: jeff@garzik•org (Jeff Garzik)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] add PATA host controller support for Cirrus Logic's EP93xx CPUs
Date: Mon, 14 Dec 2009 17:06:34 -0500 [thread overview]
Message-ID: <4B26B6EA.8050403@garzik.org> (raw)
In-Reply-To: <4B26B0D6.4080809@bluewatersys.com>
On 12/14/2009 04:40 PM, Ryan Mallon wrote:
> I have added some of my own debugging. The problem appears to be that
> __pata_ep93xx_write gets called from probe (via ata_host_activate), but
> ap->private_data (ata_timing) is still null. The timing private_data is
> set by pata_ep93xx_set_piomode, but that needs adev->pio_mode set, but I
> don't know where this happens. I assume the ATA core handles this. Do I
> need to call pata_ep93xx_set_piomode from pata_ep93xx_probe before
> ata_host_activate, or should the private_data timing be set to some
> default in the probe?
ap->private_data is traditionally initialized in the ->port_start() hook.
Likely, you should follow other drivers and allocate a useful data
structure containing useful default values, which can then be adjusted
in other hooks such as ->set_dmamode() or ->set_piomode()
Jeff
next prev parent reply other threads:[~2009-12-14 22:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 15:51 [PATCH] add PATA host controller support for Cirrus Logic's EP93xx CPUs Bartlomiej Zolnierkiewicz
2009-11-26 17:03 ` Alan Cox
2009-11-26 19:46 ` Ryan Mallon
2009-11-26 22:15 ` João Ramos
2009-12-02 0:53 ` Ryan Mallon
2009-12-02 1:06 ` Bartlomiej Zolnierkiewicz
2009-12-02 1:16 ` H Hartley Sweeten
2009-12-02 1:26 ` Ryan Mallon
2009-12-14 21:40 ` Ryan Mallon
2009-12-14 22:06 ` Jeff Garzik [this message]
2010-01-05 18:56 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B26B6EA.8050403@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox