From: viresh.kumar@st•com (Viresh KUMAR)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] Watchdog: Adding support for Watchdog found with ARM CortexA9
Date: Wed, 19 May 2010 12:15:07 +0530 [thread overview]
Message-ID: <4BF388F3.6060500@st.com> (raw)
In-Reply-To: <EAF47CD23C76F840A9E7FCE10091EFAB02C5666270@dbde02.ent.ti.com>
On 5/19/2010 11:02 AM, Shilimkar, Santosh wrote:
>> -----Original Message-----
>> From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-arm-kernel-
>> bounces at lists.infradead.org] On Behalf Of Viresh KUMAR
>> Sent: Wednesday, May 19, 2010 9:33 AM
>> To: George G. Davis; srinidhi kasagar; alan at lxorguk.ukuu.org.uk
>> Cc: armando.visconti at st.com; shiraz.hashim at st.com; Jassi Brar; linus.walleij at stericsson.com; linux-
>> arm-kernel at lists.infradead.org
>> Subject: Re: [PATCH] Watchdog: Adding support for Watchdog found with ARM CortexA9
>>
>> On 5/18/2010 6:50 PM, George G. Davis wrote:
>>> Hi,
>>>
>>> On Tue, May 18, 2010 at 02:55:21PM +0530, srinidhi kasagar wrote:
>>>> I do not understand why a new driver is required while having similar one
>>>> for MPCore watchdog.
>>>> Please have a look at drivers/watchdog/mpcore_wdt.c
>>>
>>> The same thought occurred to me. Based on a cursory glance at the Cortex-A9
>>> MPCore and ARM11 MPCore, the per-CPU watchdogs do appear to be the same
>>> and could use the same driver.
>>>
>>> Any reason for creating a new driver rather than reusing the ARM11
>>> MPCore driver?
>>>
>>
>> Sorry Guys!!! Earlier I tried to find existing driver, but couldn't found one.
>> So sent a new one.
>>
>> I went through this driver and found some shortcomings in it:
>> - It looks it is not used by anyone now, as it required
>> asm/hardware/arm_twd.h and it was removed in v2.6.31.
>> So it would never compile.
>> - It doesn't support clock framework, and works on fixed rate.
>> - It works on fixed prescale value (256).
>> - It doesn't support WDIOC_GETBOOTSTATUS.
>>
>> So, please suggest how to proceed as my patch contains all these features.
>>
> Can the existing driver be upgraded with all above missing pieces?
>
yes. will be done.
prev parent reply other threads:[~2010-05-19 6:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 9:54 [PATCH] Watchdog: Adding support for Watchdog found with ARM CortexA9 Viresh KUMAR
2010-05-17 9:56 ` Viresh KUMAR
2010-05-17 10:44 ` Jassi Brar
2010-05-17 11:24 ` Viresh KUMAR
2010-05-18 9:25 ` srinidhi kasagar
2010-05-18 13:20 ` George G. Davis
2010-05-19 4:02 ` Viresh KUMAR
2010-05-19 5:17 ` srinidhi kasagar
2010-05-19 6:44 ` Viresh KUMAR
2010-09-22 15:36 ` mpcore_wdt A9 questions John Linn
2010-09-22 15:56 ` George G. Davis
2010-05-19 5:32 ` [PATCH] Watchdog: Adding support for Watchdog found with ARM CortexA9 Shilimkar, Santosh
2010-05-19 6:45 ` Viresh KUMAR [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF388F3.6060500@st.com \
--to=viresh.kumar@st$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox