From: sshtylyov@mvista•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/5] [WATCHDOG] s3c2410_wdt - Avoid freeing memory, if memory region could not be allocated
Date: Thu, 20 May 2010 14:00:05 +0400 [thread overview]
Message-ID: <4BF50825.2060403@ru.mvista.com> (raw)
In-Reply-To: <1274340092-10706-3-git-send-email-kgene.kim@samsung.com>
Hello.
Kukjin Kim wrote:
> From: Banajit Goswami <banajit.g@samsung•com>
> In case the WDT device memory allocation fails, this patch modifies the
This is not memory allocation.
> driver such that, it does not try to free the memory on exit.
> Signed-off-by: Banajit Goswami <banajit.g@samsung•com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung•com>
> ---
> drivers/watchdog/s3c2410_wdt.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c
> index e4cebef..d421258 100644
> --- a/drivers/watchdog/s3c2410_wdt.c
> +++ b/drivers/watchdog/s3c2410_wdt.c
> @@ -426,8 +426,7 @@ static int __devinit s3c2410wdt_probe(struct platform_device *pdev)
> wdt_mem = request_mem_region(res->start, size, pdev->name);
> if (wdt_mem == NULL) {
> dev_err(dev, "failed to get memory region\n");
> - ret = -ENOENT;
> - goto err_req;
> + return -ENOMEM;
It should be EBUSY actually...
WBR, Sergei
next prev parent reply other threads:[~2010-05-20 10:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 7:21 [PATCH 0/0] Add Watchdog support for Samsung SMDK6410, S5P6440 and S5Pv210 Kukjin Kim
2010-05-20 7:21 ` [PATCH 1/5] ARM: SAMSUNG: Move WDT device definitions in plat-samsung Kukjin Kim
2010-05-20 7:43 ` Ben Dooks
2010-05-20 7:21 ` [PATCH 2/5] [WATCHDOG] s3c2410_wdt - Avoid freeing memory, if memory region could not be allocated Kukjin Kim
2010-05-20 10:00 ` Sergei Shtylyov [this message]
2010-05-20 10:32 ` Kukjin Kim
2010-05-20 7:21 ` [PATCH 3/5] ARM: SMDK6410: Add Watchdog support for SMDK6410 Kukjin Kim
2010-05-20 7:21 ` [PATCH 4/5] ARM: S5P6440: Add Watchdog support for S5P6440 Kukjin Kim
2010-05-20 7:21 ` [PATCH 5/5] ARM: S5PV210: Add Watchdog support for S5PV210 Kukjin Kim
2010-05-20 7:35 ` [PATCH 0/0] Add Watchdog support for Samsung SMDK6410, S5P6440 and S5Pv210 Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF50825.2060403@ru.mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox