From: sshtylyov@mvista•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] s3c24xx fix: freeze during suspend/resume on s3c24xx if some GPIO banks not present
Date: Mon, 24 May 2010 11:57:16 +0400 [thread overview]
Message-ID: <4BFA315C.5040806@mvista.com> (raw)
In-Reply-To: <4BF920EF.2050800@vscht.cz>
Hello.
Pinkava J. wrote:
>>> When saving GPIOs during suspend/resume we need skip missing GPIO banks, not
>>> trying get corresponding chip again and again in infinite loop.
>> I didn't see any infinite loops there -- *continue* itself leads to
>> incrementing 'gpio_nr', no?
> No, it would have to be:
> for (gpio_nr = 0; gpio_nr < S3C_GPIO_END; gpio_nr++) {
> ...
> try create simple test program for your self
> /* test.c */
> main()
> {
> int x;
> for(x = 0; x < 10; /* x++ */ )
> {
> printf("x = %d", x);
> }
> }
> Compile usign:
> gcc test.c
> Run
> ./a.out
Ah, I missed the empty 3rd expression in *for*, sorry. :-<
Strange loop though...
>>> Signed-off-by: Jiri Pinkava <jiri.pinkava@vscht•cz>
>>> ---
>>> arch/arm/plat-samsung/pm-gpio.c | 8 ++++++--
>>> 1 files changed, 6 insertions(+), 2 deletions(-)
>>> diff --git a/arch/arm/plat-samsung/pm-gpio.c b/arch/arm/plat-samsung/pm-gpio.c
>>> index d50ab9d..7df03f8 100644
>>> --- a/arch/arm/plat-samsung/pm-gpio.c
>>> +++ b/arch/arm/plat-samsung/pm-gpio.c
>>> @@ -331,8 +331,10 @@ void s3c_pm_save_gpios(void)
>>>
>>> for (gpio_nr = 0; gpio_nr < S3C_GPIO_END;) {
>>> ourchip = s3c_gpiolib_getchip(gpio_nr);
>>> - if (!ourchip)
>>> + if (!ourchip) {
>>> + gpio_nr++;
>>> continue;
>>> + }
>>>
>>> s3c_pm_save_gpio(ourchip);
>>>
>>> @@ -369,8 +371,10 @@ void s3c_pm_restore_gpios(void)
>>>
>>> for (gpio_nr = 0; gpio_nr < S3C_GPIO_END;) {
>>> ourchip = s3c_gpiolib_getchip(gpio_nr);
>>> - if (!ourchip)
>>> + if (!ourchip) {
>>> + gpio_nr++;
>>> continue;
>>> + }
>>>
>>> s3c_pm_resume_gpio(ourchip);
WBR, Sergei
next prev parent reply other threads:[~2010-05-24 7:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 4:42 [PATCH] s3c24xx fix: freeze during suspend/resume on s3c24xx if some GPIO banks not present Pinkava J.
2010-05-23 9:19 ` Sergei Shtylyov
2010-05-23 12:34 ` Pinkava J.
2010-05-24 7:57 ` Sergei Shtylyov [this message]
2010-05-24 3:32 ` Ben Dooks
2010-05-23 13:18 ` Pinkava J.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFA315C.5040806@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox