From: ryan@bluewatersys•com (Ryan Mallon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ep93xx: clear devcfg bits before setting them
Date: Mon, 14 Jun 2010 10:46:21 +1200 [thread overview]
Message-ID: <4C155FBD.4020106@bluewatersys.com> (raw)
In-Reply-To: <0D753D10438DA54287A00B027084269763711321BA@AUSP01VMBX24.collaborationhost.net>
H Hartley Sweeten wrote:
> The ep93xx core helper function ep93xx_devcfg_set_clear should mask the
> clear_bits before setting the new set_bits in case the clear_bits are a
> mask value that also includes the set_bits.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers•com>
> Cc: Ryan Mallon <ryan@bluewatersys•com>
Acked-by: Ryan Mallon <ryan@bluewatersys•com>
> ---
>
> diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c
> index 9092677..92f2ebb 100644
> --- a/arch/arm/mach-ep93xx/core.c
> +++ b/arch/arm/mach-ep93xx/core.c
> @@ -215,8 +215,8 @@ void ep93xx_devcfg_set_clear(unsigned int set_bits, unsigned int clear_bits)
> spin_lock_irqsave(&syscon_swlock, flags);
>
> val = __raw_readl(EP93XX_SYSCON_DEVCFG);
> - val |= set_bits;
> val &= ~clear_bits;
> + val |= set_bits;
> __raw_writel(0xaa, EP93XX_SYSCON_SWLOCK);
> __raw_writel(val, EP93XX_SYSCON_DEVCFG);
>
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
prev parent reply other threads:[~2010-06-13 22:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-12 0:09 [PATCH] ep93xx: clear devcfg bits before setting them H Hartley Sweeten
2010-06-13 22:46 ` Ryan Mallon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C155FBD.4020106@bluewatersys.com \
--to=ryan@bluewatersys$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox